Use more entities in program_builder, collector and registry

Use more entities in program_builder, collector and registry

This a step towards decoupling the emitter from the choice of codegen element model.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/600ecf5e7268861ab995163d7c717732c4d46246

[Johnni Winther, 2017-04-27 08:38:32]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-04-27 21:24:18]

lgtm

https://codereview.chromium.org/2843283004/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/registry.dart (right):

https://codereview.chromium.org/2843283004/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/registry.dart:7: class
LibraryMapping {
nit: rename? (because "mapping" below is used to refer to the actual mapping)

ideas:
- LibraryContents
- LibraryBody
- LibraryClassesNadMembers
- OutputEntitites (is it meant to be entities that are generated in the end?)

[Johnni Winther, 2017-04-28 07:48:57]

https://codereview.chromium.org/2843283004/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/registry.dart (right):

https://codereview.chromium.org/2843283004/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/registry.dart:7: class
LibraryMapping {
On 2017/04/27 21:24:18, Siggi Cherem (dart-lang) wrote:
> nit: rename? (because "mapping" below is used to refer to the actual mapping)
> 
> ideas:
> - LibraryContents
> - LibraryBody
> - LibraryClassesNadMembers
> - OutputEntitites (is it meant to be entities that are generated in the end?)

LibraryContents it is.

[Johnni Winther, 2017-04-28 07:53:51]

Description was changed from

==========
Use more entities in program_builder, collector and registry

This a step towards decoupling the emitter from the choice of codegen element
model.
==========

to

==========
Use more entities in program_builder, collector and registry

This a step towards decoupling the emitter from the choice of codegen element
model.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/600ecf5e7268861ab995163d7c717732c4d46246
==========

[Johnni Winther, 2017-04-28 07:53:52]

Committed patchset #3 (id:40001) manually as
600ecf5e7268861ab995163d7c717732c4d46246 (presubmit successful).