Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 284323003: Add missing call to SetUpOnMainThread to fix test crash (Closed)

Created:
6 years, 7 months ago by michaelpg
Modified:
6 years, 7 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing call to SetUpOnMainThread to fix test crash This test is flaky on my machine without this patch. Separated from issue 270563002. BUG= TEST=LoginStateNotificationBlockerChromeOSBrowserTest TBR=mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 7 months ago (2014-05-16 04:17:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/284323003/1
6 years, 7 months ago (2014-05-16 04:18:13 UTC) #2
Jun Mukai
lgtm
6 years, 7 months ago (2014-05-16 04:19:17 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 09:10:24 UTC) #4
Message was sent while issue was closed.
Change committed as 270969

Powered by Google App Engine
This is Rietveld 408576698