Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 284323002: ozone: Remove InputMethodContextFactoryOzone and FakeInputMethodContextOzone. (Closed)

Created:
6 years, 7 months ago by sadrul
Modified:
6 years, 7 months ago
Reviewers:
spang, sky, Yuki
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, kalyank, James Su
Visibility:
Public.

Description

ozone: Remove InputMethodContextFactoryOzone and FakeInputMethodContextOzone. FakeInputMethodContextOzone is the same as FakeInputMethodContext, and there's no other use for InputMethodContextFactoryOzone. So remove both. The ozone platform can directly set an IME context using LinuxInputMethodContextFactory::SetInstance if so desired. BUG=361137 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271170

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -195 lines) Patch
M content/public/test/content_browser_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_initializer.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/ozone/ime/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ui/ozone/ime/fake_input_method_context_ozone.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/ozone/ime/fake_input_method_context_ozone.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/ozone/ime/ime.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D ui/ozone/ime/input_method_context_factory_ozone.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ui/ozone/ime/input_method_context_factory_ozone.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/ozone_platform.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/ozone/ozone_platform.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 4 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
https://codereview.chromium.org/284323002/diff/40001/ui/ozone/platform/dri/dri.gypi File ui/ozone/platform/dri/dri.gypi (right): https://codereview.chromium.org/284323002/diff/40001/ui/ozone/platform/dri/dri.gypi#newcode22 ui/ozone/platform/dri/dri.gypi:22: '../base/ui_base.gyp:ui_base', This is necessary because of BitmapCursorFactoryOzone. It used ...
6 years, 7 months ago (2014-05-16 13:39:52 UTC) #1
spang
lgtm
6 years, 7 months ago (2014-05-16 14:41:53 UTC) #2
sadrul
+sky@ for content/browser/ changes. +yukishhino@ for ui/base/ime/ changes.
6 years, 7 months ago (2014-05-16 17:19:52 UTC) #3
sky
LGTM
6 years, 7 months ago (2014-05-16 17:36:54 UTC) #4
Yuki
lgtm
6 years, 7 months ago (2014-05-17 03:40:54 UTC) #5
sadrul
6 years, 7 months ago (2014-05-17 05:15:30 UTC) #6
Message was sent while issue was closed. 
Manually committed in r271170

Powered by Google App Engine
This is Rietveld 408576698