Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2843223005: [inspector_protocol] added StringUtil::toDouble method as requirement (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] added StringUtil::toDouble method as requirement This method should convert passed string to double ignoring current locale (decimal pointer). BUG=chromium:712610 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocolefefa86c3183d307f0a0e53bf568fe57c5b58849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M lib/Parser_cpp.template View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kozy
Dmitry, please take a look.
3 years, 7 months ago (2017-04-27 21:43:59 UTC) #1
dgozman
lgtm
3 years, 7 months ago (2017-04-27 22:59:39 UTC) #2
kozy
3 years, 7 months ago (2017-04-28 00:09:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
efefa86c3183d307f0a0e53bf568fe57c5b58849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698