third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js - Issue 2843203003: DevTools: pressing enter in bound input fields should not fire change handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 2843203003: DevTools: pressing enter in bound input fields should not fire change handler (Closed)

Patch Set: keep enter listener and add preventDefault Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

index d2d831687423820b9c2657c6cf241453dc47f02f..b771c66cd6fd8dde5f5bf004dadba4fbe2f0b754 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

@@ -1561,6 +1561,7 @@ UI.bindInput = function(input, apply, validate, numeric) {

if (isEnterKey(event)) {

if (validate(input.value))

apply(input.value);

+ event.preventDefault();

return;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »