ash/system/network/network_list_view_base.cc - Issue 2843163003: Remove NetworkListDelegate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/system/network/network_list_view_base.cc

Issue 2843163003: Remove NetworkListDelegate (Closed)

Patch Set: Cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/system/network/network_list_view_base.h ('K') | « ash/system/network/network_list_view_base.h ('k') | ash/system/network/network_state_list_detailed_view.h » ('j') | ash/system/network/vpn_list_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/system/network/network_list_view_base.h"	5 #include "ash/system/network/network_list_view_base.h"

6	6

	7 #include "base/logging.h"

	8

7 namespace ash {	9 namespace ash {

8	10

9 NetworkListViewBase::NetworkListViewBase() {}	11 NetworkListViewBase::NetworkListViewBase(

	12 tray::NetworkStateListDetailedView* detailed_view)

	13 : detailed_view_(detailed_view) {

	14 DCHECK(detailed_view_);
	tdanderson 2017/04/28 16:36:20 I am not sure if this DCHECK is necessary, since i I am not sure if this DCHECK is necessary, since if someone did instantiate a NLVB with a null \|detailed_view\| then the failure would be caught by the first call to detailed_view_->* mohsen 2017/04/28 21:51:32 Yes, but this DCHECK here makes the contract expli Show quoted text On 2017/04/28 at 16:36:20, tdanderson wrote: > I am not sure if this DCHECK is necessary, since if someone did instantiate a NLVB with a null \|detailed_view\| then the failure would be caught by the first call to detailed_view_->* Yes, but this DCHECK here makes the contract explicit that \|detailed_view_\| should not be null. Also, it would be easier to debug if it is caught here rather than some random place that calls into \|detailed_view_\| first.
	15 }

10	16

11 NetworkListViewBase::~NetworkListViewBase() {}	17 NetworkListViewBase::~NetworkListViewBase() {}

12	18

13 } // namespace ash	19 } // namespace ash

OLD	NEW