Remove NetworkListDelegate

ash/system/network/network_list.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/network/network_list.h"
 
-#include <stddef.h>
+#include <memory>
 
+#include "ash/shell.h"
+#include "ash/shell_port.h"
 #include "ash/strings/grit/ash_strings.h"
 #include "ash/system/network/network_icon.h"
 #include "ash/system/network/network_icon_animation.h"
-#include "ash/system/network/network_list_delegate.h"
+#include "ash/system/network/network_info.h"
+#include "ash/system/network/network_state_list_detailed_view.h"
+#include "ash/system/networking_config_delegate.h"
+#include "ash/system/tray/fixed_sized_image_view.h"
+#include "ash/system/tray/hover_highlight_view.h"
 #include "ash/system/tray/system_menu_button.h"
+#include "ash/system/tray/system_tray_controller.h"
+#include "ash/system/tray/system_tray_delegate.h"
+#include "ash/system/tray/throbber_view.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_popup_item_style.h"
 #include "ash/system/tray/tray_popup_utils.h"
 #include "ash/system/tray/tri_view.h"
 #include "base/memory/ptr_util.h"
+#include "base/strings/string16.h"
+#include "base/strings/utf_string_conversions.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/power_manager/power_supply_properties.pb.h"
 #include "chromeos/dbus/power_manager_client.h"
 #include "chromeos/login/login_state.h"
 #include "chromeos/network/managed_network_configuration_handler.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
 #include "chromeos/network/network_state_handler_observer.h"
 #include "chromeos/network/proxy/ui_proxy_config_service.h"
 #include "components/device_event_log/device_event_log.h"
+#include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/font.h"
+#include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/paint_vector_icon.h"
+#include "ui/gfx/text_constants.h"
 #include "ui/views/background.h"
+#include "ui/views/border.h"
 #include "ui/views/controls/button/toggle_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/controls/separator.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/painter.h"
 #include "ui/views/view.h"
 
 using chromeos::LoginState;
@@ skipping 21 matching lines @@
     global_network_config->GetBooleanWithoutPathExpansion(
         ::onc::global_network_config::kAllowOnlyPolicyNetworksToConnect,
         &policy_prohibites_unmanaged);
   }
   if (!policy_prohibites_unmanaged)
     return false;
   return !managed_configuration_handler->FindPolicyByGuidAndProfile(
       network->guid(), network->profile_path());
 }
 
+// TODO(varkha|mohsen): Consolidate with a similar method in tray_bluetooth.cc.

[tdanderson, 2017/04/28 16:36:20]

Can you please reference crbug.com/686924 here?

[mohsen, 2017/04/28 21:51:32]

Done.

+void SetupConnectedItem(HoverHighlightView* container,
+                        const base::string16& text,
+                        const gfx::ImageSkia& image) {
+  container->AddIconAndLabels(
+      image, text,
+      l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_NETWORK_STATUS_CONNECTED));
+  TrayPopupItemStyle style(TrayPopupItemStyle::FontStyle::CAPTION);
+  style.set_color_style(TrayPopupItemStyle::ColorStyle::CONNECTED);
+  style.SetupLabel(container->sub_text_label());
+}
+
+// TODO(varkha|mohsen): Consolidate with a similar method in tray_bluetooth.cc.
+void SetupConnectingItem(HoverHighlightView* container,
+                         const base::string16& text,
+                         const gfx::ImageSkia& image) {
+  container->AddIconAndLabels(
+      image, text,
+      l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_NETWORK_STATUS_CONNECTING));
+  ThrobberView* throbber = new ThrobberView;
+  throbber->Start();
+  container->AddRightView(throbber);
+}
+
 }  // namespace
 
 // A header row for sections in network detailed view which contains a title and
 // a toggle button to turn on/off the section. Subclasses are given the
 // opportunity to add extra buttons before the toggle button is added.
 class NetworkListView::SectionHeaderRowView : public views::View,
                                               public views::ButtonListener {
  public:
   explicit SectionHeaderRowView(int title_id)
       : title_id_(title_id),
@@ skipping 117 matching lines @@
   void OnToggleToggled(bool is_on) override {
     // TODO (hansberry): Persist toggle to settings/preferences.
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TetherHeaderRowView);
 };
 
 class WifiHeaderRowView : public NetworkListView::SectionHeaderRowView {
  public:
-  explicit WifiHeaderRowView(NetworkListDelegate* network_list_delegate)
+  WifiHeaderRowView()
       : SectionHeaderRowView(IDS_ASH_STATUS_TRAY_NETWORK_WIFI),
-        network_list_delegate_(network_list_delegate),
         join_(nullptr) {}
 
   ~WifiHeaderRowView() override {}
 
   void SetIsOn(bool enabled) override {
     join_->SetEnabled(enabled);
     SectionHeaderRowView::SetIsOn(enabled);
   }
 
   const char* GetClassName() const override { return "WifiHeaderRowView"; }
@@ skipping 19 matching lines @@
     join_ = new SystemMenuButton(this, TrayPopupInkDropStyle::HOST_CENTERED,
                                  normal_image, disabled_image,
                                  IDS_ASH_STATUS_TRAY_OTHER_WIFI);
     join_->SetInkDropColor(prominent_color);
     join_->SetEnabled(enabled);
     container()->AddView(TriView::Container::END, join_);
   }
 
   void ButtonPressed(views::Button* sender, const ui::Event& event) override {
     if (sender == join_) {
-      network_list_delegate_->OnOtherWifiClicked();
+      ShellPort::Get()->RecordUserMetricsAction(
+          UMA_STATUS_AREA_NETWORK_JOIN_OTHER_CLICKED);
+      Shell::Get()->system_tray_controller()->ShowNetworkCreate(
+          shill::kTypeWifi);
       return;
     }
     SectionHeaderRowView::ButtonPressed(sender, event);
   }
 
  private:
   // Full opacity for badge.
   static constexpr int kJoinBadgeAlpha = 0xFF;
 
   // .30 opacity for icon.
   static constexpr int kJoinIconAlpha = 0x4D;
 
   // .38 opacity for disabled badge.
   static constexpr int kDisabledJoinBadgeAlpha = 0x61;
 
   // .30 * .38 opacity for disabled icon.
   static constexpr int kDisabledJoinIconAlpha = 0x1D;
 
-  NetworkListDelegate* network_list_delegate_;
-
   // A button to invoke "Join Wi-Fi network" dialog.
   SystemMenuButton* join_;
 
   DISALLOW_COPY_AND_ASSIGN(WifiHeaderRowView);
 };
 
 }  // namespace
 
 // NetworkListView:
 
-NetworkListView::NetworkListView(NetworkListDelegate* delegate)
-    : needs_relayout_(false),
-      delegate_(delegate),
+NetworkListView::NetworkListView(
+    tray::NetworkStateListDetailedView* detailed_view)
+    : NetworkListViewBase(detailed_view),
+      needs_relayout_(false),
       no_wifi_networks_view_(nullptr),
       no_cellular_networks_view_(nullptr),
       cellular_header_view_(nullptr),
       tether_header_view_(nullptr),
       wifi_header_view_(nullptr),
       cellular_separator_view_(nullptr),
       tether_separator_view_(nullptr),
       wifi_separator_view_(nullptr),
-      connection_warning_(nullptr) {
-  CHECK(delegate_);
-}
+      connection_warning_(nullptr) {}
 
 NetworkListView::~NetworkListView() {
   network_icon::NetworkIconAnimation::GetInstance()->RemoveObserver(this);
 }
 
 void NetworkListView::Update() {
   CHECK(container());
 
   NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
 
@@ skipping 28 matching lines @@
 void NetworkListView::UpdateNetworks(
     const NetworkStateHandler::NetworkStateList& networks) {
   SCOPED_NET_LOG_IF_SLOW();
   // |network_list_| contains all the info and is going to be cleared and
   // recreated. Save them to |last_network_info_map_|.
   last_network_info_map_.clear();
   for (auto& info : network_list_)
     last_network_info_map_[info->guid] = std::move(info);
 
   network_list_.clear();
-  const NetworkTypePattern pattern = delegate_->GetNetworkTypePattern();
   for (const auto* network : networks) {
-    if (!pattern.MatchesType(network->type()))
+    if (!NetworkTypePattern::NonVirtual().MatchesType(network->type()))
       continue;
 
     // Do not add Wi-Fi networks that are associated with a Tether network.
     if (NetworkTypePattern::WiFi().MatchesType(network->type()) &&
         !network->tether_guid().empty())
       continue;
 
     network_list_.push_back(base::MakeUnique<NetworkInfo>(network->guid()));
   }
 }
@@ skipping 106 matching lines @@
     return;
 
   views::View* selected_view = nullptr;
   for (const auto& iter : network_guid_map_) {
     if (iter.second->IsMouseHovered()) {
       selected_view = iter.second;
       break;
     }
   }
   container()->SizeToPreferredSize();
-  delegate_->RelayoutScrollList();
+  detailed_view()->RelayoutScrollList();
   if (selected_view)
     container()->ScrollRectToVisible(selected_view->bounds());
 }
 
 std::unique_ptr<std::set<std::string>>
 NetworkListView::UpdateNetworkListEntries() {
   NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
 
   // Keep an index where the next child should be inserted.
   int index = 0;
@@ skipping 10 matching lines @@
     if (!connection_warning_)
       connection_warning_ = CreateConnectionWarning();
     PlaceViewAtIndex(connection_warning_, index++);
   }
 
   // First add high-priority networks (not Wi-Fi nor cellular).
   std::unique_ptr<std::set<std::string>> new_guids =
       UpdateNetworkChildren(NetworkInfo::Type::UNKNOWN, index);
   index += new_guids->size();
 
-  const NetworkTypePattern pattern = delegate_->GetNetworkTypePattern();
-  if (pattern.MatchesPattern(NetworkTypePattern::Cellular())) {
-    if (handler->IsTechnologyAvailable(NetworkTypePattern::Cellular())) {
-      index = UpdateSectionHeaderRow(
-          NetworkTypePattern::Cellular(),
-          handler->IsTechnologyEnabled(NetworkTypePattern::Cellular()), index,
-          &cellular_header_view_, &cellular_separator_view_);
-    }
+  if (handler->IsTechnologyAvailable(NetworkTypePattern::Cellular())) {
+    index = UpdateSectionHeaderRow(
+        NetworkTypePattern::Cellular(),
+        handler->IsTechnologyEnabled(NetworkTypePattern::Cellular()), index,
+        &cellular_header_view_, &cellular_separator_view_);
+  }
 
-    // Cellular initializing.
-    int message_id = network_icon::GetCellularUninitializedMsg();
-    if (!message_id &&
-        handler->IsTechnologyEnabled(NetworkTypePattern::Mobile()) &&
-        !handler->FirstNetworkByType(NetworkTypePattern::Mobile())) {
-      message_id = IDS_ASH_STATUS_TRAY_NO_MOBILE_NETWORKS;
-    }
-    UpdateInfoLabel(message_id, index, &no_cellular_networks_view_);
-    if (message_id)
-      ++index;
+  // Cellular initializing.
+  int cellular_message_id = network_icon::GetCellularUninitializedMsg();
+  if (!cellular_message_id &&
+      handler->IsTechnologyEnabled(NetworkTypePattern::Mobile()) &&
+      !handler->FirstNetworkByType(NetworkTypePattern::Mobile())) {
+    cellular_message_id = IDS_ASH_STATUS_TRAY_NO_MOBILE_NETWORKS;
+  }
+  UpdateInfoLabel(cellular_message_id, index, &no_cellular_networks_view_);
+  if (cellular_message_id)
+    ++index;
 
-    // Add cellular networks.
-    std::unique_ptr<std::set<std::string>> new_cellular_guids =
-        UpdateNetworkChildren(NetworkInfo::Type::CELLULAR, index);
-    index += new_cellular_guids->size();
-    new_guids->insert(new_cellular_guids->begin(), new_cellular_guids->end());
-  }
+  // Add cellular networks.
+  std::unique_ptr<std::set<std::string>> new_cellular_guids =
+      UpdateNetworkChildren(NetworkInfo::Type::CELLULAR, index);
+  index += new_cellular_guids->size();
+  new_guids->insert(new_cellular_guids->begin(), new_cellular_guids->end());
 
   // TODO (hansberry): Audit existing usage of NonVirtual and consider changing
   // it to include Tether. See crbug.com/693647.
   if (handler->IsTechnologyAvailable(NetworkTypePattern::Tether())) {
     index = UpdateSectionHeaderRow(
         NetworkTypePattern::Tether(),
         handler->IsTechnologyEnabled(NetworkTypePattern::Tether()), index,
         &tether_header_view_, &tether_separator_view_);
 
     // TODO (hansberry): Should a message similar to
-    // IDS_ASH_STATUS_TRAY_NO_CELLULAR_NETWORKS be shown if Tether technology
-    // is enabled but no networks are around?
+    // IDS_ASH_STATUS_TRAY_NO_CELLULAR_NETWORKS be shown if Tether technology is
+    // enabled but no networks are around?
 
     // Add Tether networks.
     std::unique_ptr<std::set<std::string>> new_tether_guids =
         UpdateNetworkChildren(NetworkInfo::Type::TETHER, index);
     index += new_tether_guids->size();
     new_guids->insert(new_tether_guids->begin(), new_tether_guids->end());
   }
 
-  if (pattern.MatchesPattern(NetworkTypePattern::WiFi())) {
-    index = UpdateSectionHeaderRow(
-        NetworkTypePattern::WiFi(),
-        handler->IsTechnologyEnabled(NetworkTypePattern::WiFi()), index,
-        &wifi_header_view_, &wifi_separator_view_);
+  index = UpdateSectionHeaderRow(
+      NetworkTypePattern::WiFi(),
+      handler->IsTechnologyEnabled(NetworkTypePattern::WiFi()), index,
+      &wifi_header_view_, &wifi_separator_view_);
 
-    // "Wifi Enabled / Disabled".
-    int message_id = 0;
-    if (network_list_.empty()) {
-      message_id = handler->IsTechnologyEnabled(NetworkTypePattern::WiFi())
-                       ? IDS_ASH_STATUS_TRAY_NETWORK_WIFI_ENABLED
-                       : IDS_ASH_STATUS_TRAY_NETWORK_WIFI_DISABLED;
-    }
-    UpdateInfoLabel(message_id, index, &no_wifi_networks_view_);
-    if (message_id)
-      ++index;
+  // "Wifi Enabled / Disabled".
+  int wifi_message_id = 0;
+  if (network_list_.empty()) {
+    wifi_message_id = handler->IsTechnologyEnabled(NetworkTypePattern::WiFi())
+                          ? IDS_ASH_STATUS_TRAY_NETWORK_WIFI_ENABLED
+                          : IDS_ASH_STATUS_TRAY_NETWORK_WIFI_DISABLED;
+  }
+  UpdateInfoLabel(wifi_message_id, index, &no_wifi_networks_view_);
+  if (wifi_message_id)
+    ++index;
 
-    // Add Wi-Fi networks.
-    std::unique_ptr<std::set<std::string>> new_wifi_guids =
-        UpdateNetworkChildren(NetworkInfo::Type::WIFI, index);
-    index += new_wifi_guids->size();
-    new_guids->insert(new_wifi_guids->begin(), new_wifi_guids->end());
-  }
+  // Add Wi-Fi networks.
+  std::unique_ptr<std::set<std::string>> new_wifi_guids =
+      UpdateNetworkChildren(NetworkInfo::Type::WIFI, index);
+  index += new_wifi_guids->size();
+  new_guids->insert(new_wifi_guids->begin(), new_wifi_guids->end());
 
   // No networks or other messages (fallback).
   if (index == 0) {
     UpdateInfoLabel(IDS_ASH_STATUS_TRAY_NO_NETWORKS, index,
                     &no_wifi_networks_view_);
   }
 
   return new_guids;
 }
 
+views::View* NetworkListView::CreateViewForNetwork(const NetworkInfo& info) {
+  HoverHighlightView* container = new HoverHighlightView(detailed_view());
+  if (info.connected)
+    SetupConnectedItem(container, info.label, info.image);
+  else if (info.connecting)
+    SetupConnectingItem(container, info.label, info.image);
+  else
+    container->AddIconAndLabel(info.image, info.label);
+  container->SetTooltipText(info.tooltip);
+  views::View* controlled_icon = CreateControlledByExtensionView(info);
+  if (controlled_icon)
+    container->AddChildView(controlled_icon);
+  return container;
+}
+
+void NetworkListView::UpdateViewForNetwork(views::View* view,
+                                           const NetworkInfo& info) {
+  HoverHighlightView* container = static_cast<HoverHighlightView*>(view);

[tdanderson, 2017/04/28 16:36:20]

WDYT of having CreateViewForNetwork() return a HoverHighlightView? Then you can
have UpdateViewForNetwork() take in a HHV, which would allow you to avoid this
static_cast.

[mohsen, 2017/04/28 21:51:32]

Sure. Done.

+  DCHECK(!container->has_children());
+  if (info.connected)
+    SetupConnectedItem(container, info.label, info.image);
+  else if (info.connecting)
+    SetupConnectingItem(container, info.label, info.image);
+  else
+    container->AddIconAndLabel(info.image, info.label);
+  views::View* controlled_icon = CreateControlledByExtensionView(info);
+  container->SetTooltipText(info.tooltip);
+  if (controlled_icon)
+    view->AddChildView(controlled_icon);
+}
+
+views::View* NetworkListView::CreateControlledByExtensionView(
+    const NetworkInfo& info) {
+  NetworkingConfigDelegate* networking_config_delegate =
+      Shell::Get()->system_tray_delegate()->GetNetworkingConfigDelegate();
+  if (!networking_config_delegate)
+    return nullptr;
+  std::unique_ptr<const NetworkingConfigDelegate::ExtensionInfo>
+      extension_info =
+          networking_config_delegate->LookUpExtensionForNetwork(info.guid);
+  if (!extension_info)
+    return nullptr;
+
+  // Get the tooltip text.
+  base::string16 tooltip_text = l10n_util::GetStringFUTF16(
+      IDS_ASH_STATUS_TRAY_EXTENSION_CONTROLLED_WIFI,
+      base::UTF8ToUTF16(extension_info->extension_name));
+
+  views::ImageView* controlled_icon =
+      new FixedSizedImageView(kTrayPopupDetailsIconWidth, 0);
+
+  controlled_icon->SetImage(
+      gfx::CreateVectorIcon(kCaptivePortalIcon, kMenuIconColor));
+  controlled_icon->SetTooltipText(tooltip_text);
+  return controlled_icon;
+}
+
 std::unique_ptr<std::set<std::string>> NetworkListView::UpdateNetworkChildren(
     NetworkInfo::Type type,
     int index) {
   std::unique_ptr<std::set<std::string>> new_guids(new std::set<std::string>);
   for (const auto& info : network_list_) {
     if (info->type != type)
       continue;
     UpdateNetworkChild(index++, info.get());
     new_guids->insert(info->guid);
   }
   return new_guids;
 }
 
 void NetworkListView::UpdateNetworkChild(int index, const NetworkInfo* info) {
   views::View* network_view = nullptr;
   NetworkGuidMap::const_iterator found = network_guid_map_.find(info->guid);
   if (found == network_guid_map_.end()) {
-    network_view = delegate_->CreateViewForNetwork(*info);
+    network_view = CreateViewForNetwork(*info);
   } else {
     network_view = found->second;
     if (NeedUpdateViewForNetwork(*info)) {
       network_view->RemoveAllChildViews(true);
-      delegate_->UpdateViewForNetwork(network_view, *info);
+      UpdateViewForNetwork(network_view, *info);
       network_view->Layout();
       network_view->SchedulePaint();
     }
   }
   PlaceViewAtIndex(network_view, index);
   if (info->disable)
     network_view->SetEnabled(false);
   network_map_[network_view] = info->guid;
   network_guid_map_[info->guid] = network_view;
 }
@@ skipping 16 matching lines @@
   if (!message_id) {
     if (label) {
       needs_relayout_ = true;
       delete label;
       *label_ptr = nullptr;
     }
     return;
   }
   base::string16 text =
       ui::ResourceBundle::GetSharedInstance().GetLocalizedString(message_id);
-  if (!label)
-    label = delegate_->CreateInfoLabel();
+  if (!label) {
+    label = new views::Label();

[tdanderson, 2017/04/28 16:36:20]

Can you add a TODO(mohsen) here saying this should follow MD specs, and link to
crbug.com/687778 ?

[mohsen, 2017/04/28 21:51:32]

Done.

+    label->SetBorder(views::CreateEmptyBorder(
+        kTrayPopupPaddingBetweenItems, kTrayPopupPaddingHorizontal,
+        kTrayPopupPaddingBetweenItems, 0));
+    label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+    label->SetEnabledColor(SkColorSetARGB(192, 0, 0, 0));
+  }
   label->SetText(text);
   PlaceViewAtIndex(label, insertion_index);
   *label_ptr = label;
 }
 
 int NetworkListView::UpdateSectionHeaderRow(NetworkTypePattern pattern,
                                             bool enabled,
                                             int child_index,
                                             SectionHeaderRowView** view,
                                             views::Separator** separator_view) {
   if (!*view) {
     if (pattern.Equals(NetworkTypePattern::Cellular()))
       *view = new CellularHeaderRowView();
     else if (pattern.Equals(NetworkTypePattern::Tether()))
       *view = new TetherHeaderRowView();
     else if (pattern.Equals(NetworkTypePattern::WiFi()))
-      *view = new WifiHeaderRowView(delegate_);
+      *view = new WifiHeaderRowView();
     else
       NOTREACHED();
     (*view)->Init(enabled);
   }
   // Show or hide a separator above the header. The separator should only be
   // visible when the header row is not at the top of the list.
   if (child_index > 0) {
     if (!*separator_view)
       *separator_view = TrayPopupUtils::CreateListSubHeaderSeparator();
     PlaceViewAtIndex(*separator_view, child_index++);
@@ skipping 47 matching lines @@
   TrayPopupItemStyle style(TrayPopupItemStyle::FontStyle::DETAILED_VIEW_LABEL);
   style.SetupLabel(label);
   connection_warning->AddView(TriView::Container::CENTER, label);
 
   // Nothing to the right of the text.
   connection_warning->SetContainerVisible(TriView::Container::END, false);
   return connection_warning;
 }
 
 }  // namespace ash