Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 284313016: Fix HWNDMessageHandler::OnSetCursor handling of HTERROR. (Closed)

Created:
6 years, 7 months ago by msw
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix HWNDMessageHandler::OnSetCursor handling of HTERROR. Handling HTERROR WM_SETCURSOR messages apparently causes a regression. Modals don't pulse, beep, and come foreground when the parent is clicked. This originally regressed with my http://crrev.com/188817. BUG=375181 TEST=Clicking a browser with a window-modal dialog causes the dialog to pulse, beep, and the window pair to come foreground. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
msw
Hey Scott, please take a look; I'm sorry this went unfixed for so long!
6 years, 7 months ago (2014-05-22 05:45:12 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-22 14:06:57 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 7 months ago (2014-05-22 14:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/284313016/1
6 years, 7 months ago (2014-05-22 14:55:28 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 15:29:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 15:31:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9787)
6 years, 7 months ago (2014-05-22 15:31:28 UTC) #7
msw
The CQ bit was checked by msw@chromium.org
6 years, 7 months ago (2014-05-22 15:32:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/284313016/1
6 years, 7 months ago (2014-05-22 15:33:42 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 15:37:32 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 15:39:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9787)
6 years, 7 months ago (2014-05-22 15:39:49 UTC) #12
msw
The CQ bit was checked by msw@chromium.org
6 years, 7 months ago (2014-05-22 22:53:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/284313016/1
6 years, 7 months ago (2014-05-22 22:54:55 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 22:57:07 UTC) #15
Message was sent while issue was closed.
Change committed as 272353

Powered by Google App Engine
This is Rietveld 408576698