chrome/browser/translate/translate_tab_helper.cc - Issue 284313008: Move TranslateInfoBarDelegate and OptionsMenuModel to the Translate component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 284313008: Move TranslateInfoBarDelegate and OptionsMenuModel to the Translate component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_tab_helper.h ('k') | chrome/browser/ui/android/infobars/translate_infobar.cc » ('j') | components/translate/core/browser/options_menu_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_tab_helper.cc

diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc

index c6a23b913471f23904e4a213f8b8bae761c47885..0e7949b119ef5f451c1d55720a7b4bed28d90236 100644

--- a/chrome/browser/translate/translate_tab_helper.cc

+++ b/chrome/browser/translate/translate_tab_helper.cc

@@ -13,7 +13,6 @@

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/translate/translate_accept_languages_factory.h"

-#include "chrome/browser/translate/translate_infobar_delegate.h"

#include "chrome/browser/translate/translate_service.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -26,6 +25,7 @@

#include "components/translate/core/browser/page_translated_details.h"

#include "components/translate/core/browser/translate_accept_languages.h"

#include "components/translate/core/browser/translate_download_manager.h"

+#include "components/translate/core/browser/translate_infobar_delegate.h"

#include "components/translate/core/browser/translate_manager.h"

#include "components/translate/core/browser/translate_prefs.h"

#include "components/translate/core/common/language_detection_details.h"

@@ -34,6 +34,7 @@

#include "content/public/browser/notification_service.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

+#include "grit/theme_resources.h"

#include "net/http/http_status_code.h"

#include "url/gurl.h"

@@ -231,6 +232,10 @@ void TranslateTabHelper::ShowReportLanguageDetectionErrorUI(

#endif // defined(OS_ANDROID)

}

+int TranslateTabHelper::GetInfobarIconID() const {

+ return IDR_INFOBAR_TRANSLATE;

bool TranslateTabHelper::OnMessageReceived(const IPC::Message& message) {

bool handled = true;

IPC_BEGIN_MESSAGE_MAP(TranslateTabHelper, message)