Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: components/translate/core/browser/translate_infobar_delegate.cc

Issue 284313008: Move TranslateInfoBarDelegate and OptionsMenuModel to the Translate component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/translate_infobar_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_infobar_delegate.cc
diff --git a/chrome/browser/translate/translate_infobar_delegate.cc b/components/translate/core/browser/translate_infobar_delegate.cc
similarity index 91%
rename from chrome/browser/translate/translate_infobar_delegate.cc
rename to components/translate/core/browser/translate_infobar_delegate.cc
index db277adb16d5ddf378d635843d56e68284256cdd..a509077f547c8421668e19aca980ec9ebd32254b 100644
--- a/chrome/browser/translate/translate_infobar_delegate.cc
+++ b/components/translate/core/browser/translate_infobar_delegate.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/translate/translate_infobar_delegate.h"
+#include "components/translate/core/browser/translate_infobar_delegate.h"
#include <algorithm>
@@ -18,8 +18,6 @@
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/common/translate_constants.h"
#include "grit/components_strings.h"
-#include "grit/theme_resources.h"
-#include "third_party/icu/source/i18n/unicode/coll.h"
#include "ui/base/l10n/l10n_util.h"
namespace {
@@ -29,17 +27,17 @@ namespace {
// so we are more aggressive about showing the shortcut to never translate.
// The "Always Translate" option is always shown on iOS and Android.
#if defined(OS_ANDROID)
- const int kAlwaysTranslateMinCount = 1;
- const int kNeverTranslateMinCount = 1;
+const int kAlwaysTranslateMinCount = 1;
+const int kNeverTranslateMinCount = 1;
#elif defined(OS_IOS)
- // The iOS implementation, like the Android implementation, shows the "Never
- // translate" infobar after two denials. There is an offset of one because on
- // Android the last event is not counted.
- const int kAlwaysTranslateMinCount = 1;
- const int kNeverTranslateMinCount = 2;
+// The iOS implementation, like the Android implementation, shows the "Never
+// translate" infobar after two denials. There is an offset of one because on
+// Android the last event is not counted.
+const int kAlwaysTranslateMinCount = 1;
+const int kNeverTranslateMinCount = 2;
#else
- const int kAlwaysTranslateMinCount = 3;
- const int kNeverTranslateMinCount = 3;
+const int kAlwaysTranslateMinCount = 3;
+const int kNeverTranslateMinCount = 3;
#endif
} // namespace
@@ -77,10 +75,11 @@ void TranslateInfoBarDelegate::Create(
}
// Do not create the after translate infobar if we are auto translating.
+ TranslateClient* translate_client = translate_manager->translate_client();
if (((step == translate::TRANSLATE_STEP_AFTER_TRANSLATE) ||
(step == translate::TRANSLATE_STEP_TRANSLATING)) &&
- translate_manager->translate_client()->GetTranslateDriver()
- ->GetLanguageState().InTranslateNavigation()) {
+ translate_client->GetTranslateDriver()->GetLanguageState()
+ .InTranslateNavigation()) {
return;
}
@@ -98,7 +97,7 @@ void TranslateInfoBarDelegate::Create(
}
// Add the new delegate.
- scoped_ptr<infobars::InfoBar> infobar(CreateInfoBar(
+ scoped_ptr<infobars::InfoBar> infobar(translate_client->CreateInfoBar(
scoped_ptr<TranslateInfoBarDelegate>(new TranslateInfoBarDelegate(
translate_manager, is_off_the_record, step, old_delegate,
original_language, target_language, error_type,
@@ -109,7 +108,6 @@ void TranslateInfoBarDelegate::Create(
infobar_manager->AddInfoBar(infobar.Pass());
}
-
void TranslateInfoBarDelegate::UpdateOriginalLanguageIndex(
size_t language_index) {
ui_delegate_.UpdateOriginalLanguageIndex(language_index);
@@ -139,7 +137,7 @@ void TranslateInfoBarDelegate::TranslationDeclined() {
}
bool TranslateInfoBarDelegate::IsTranslatableLanguageByPrefs() {
- TranslateClient* client = GetTranslateClient();
+ TranslateClient* client = translate_manager_->translate_client();
scoped_ptr<TranslatePrefs> translate_prefs(client->GetTranslatePrefs());
TranslateAcceptLanguages* accept_languages =
client->GetTranslateAcceptLanguages();
@@ -186,7 +184,7 @@ void TranslateInfoBarDelegate::AlwaysTranslatePageLanguage() {
void TranslateInfoBarDelegate::NeverTranslatePageLanguage() {
DCHECK(!ui_delegate_.IsLanguageBlocked());
ui_delegate_.SetLanguageBlocked(true);
- infobar()->RemoveSelf();
+ infobar()->RemoveSelf();
}
base::string16 TranslateInfoBarDelegate::GetMessageInfoBarText() {
@@ -340,16 +338,6 @@ TranslateInfoBarDelegate::TranslateInfoBarDelegate(
background_animation_ = is_error() ? NORMAL_TO_ERROR : ERROR_TO_NORMAL;
}
-TranslateClient* TranslateInfoBarDelegate::GetTranslateClient() {
- if (!translate_manager_)
- return NULL;
-
- return translate_manager_->translate_client();
-}
-
-// TranslateInfoBarDelegate::CreateInfoBar() is implemented in platform-specific
-// files.
-
void TranslateInfoBarDelegate::InfoBarDismissed() {
if (step_ != translate::TRANSLATE_STEP_BEFORE_TRANSLATE)
return;
@@ -360,7 +348,7 @@ void TranslateInfoBarDelegate::InfoBarDismissed() {
}
int TranslateInfoBarDelegate::GetIconID() const {
- return IDR_INFOBAR_TRANSLATE;
+ return translate_manager_->translate_client()->GetInfobarIconID();
}
infobars::InfoBarDelegate::Type TranslateInfoBarDelegate::GetInfoBarType()
« no previous file with comments | « components/translate/core/browser/translate_infobar_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698