components/translate/core/browser/translate_client.h - Issue 284313008: Move TranslateInfoBarDelegate and OptionsMenuModel to the Translate component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/translate/core/browser/translate_client.h

Issue 284313008: Move TranslateInfoBarDelegate and OptionsMenuModel to the Translate component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/translate/core/browser/options_menu_model.cc ('K') | « components/translate/core/browser/options_menu_model.cc ('k') | components/translate/core/browser/translate_infobar_delegate.h » ('j') | components/translate/core/browser/translate_infobar_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_	5 #ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_

6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_	6 #define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/memory/ref_counted.h"	10 #include "base/memory/ref_counted.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 TranslateErrors::Type error_type,	44 TranslateErrors::Type error_type,

45 bool triggered_from_menu) = 0;	45 bool triggered_from_menu) = 0;

46	46

47 // Returns true if the URL can be translated.	47 // Returns true if the URL can be translated.

48 virtual bool IsTranslatableURL(const GURL& url) = 0;	48 virtual bool IsTranslatableURL(const GURL& url) = 0;

49	49

50 // Presents \|report_url\|, a URL containing information relating to reporting	50 // Presents \|report_url\|, a URL containing information relating to reporting

51 // a language detection error, to the user to allow them to report language	51 // a language detection error, to the user to allow them to report language

52 // detection errors as desired.	52 // detection errors as desired.

53 virtual void ShowReportLanguageDetectionErrorUI(const GURL& report_url) = 0;	53 virtual void ShowReportLanguageDetectionErrorUI(const GURL& report_url) = 0;

	54

	55 // Returns the resource ID of the icon to be shown for the Translate infobars.
	Peter Kasting 2014/05/21 20:38:24 Nit: I wonder if this should be listed higher up, Nit: I wonder if this should be listed higher up, e.g. by the other Get functions? I'm struggling to think of any logical order for these functions :/ droger 2014/05/22 12:33:37 Done. Show quoted text On 2014/05/21 20:38:24, Peter Kasting wrote: > Nit: I wonder if this should be listed higher up, e.g. by the other Get > functions? I'm struggling to think of any logical order for these functions :/ Done.
	56 virtual int GetInfobarIconID() const = 0;

54 };	57 };

55	58

56 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_	59 #endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_

OLD	NEW