Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 284313002: Add Google Now Card Type Histogram Labels (Closed)

Created:
6 years, 7 months ago by robliao
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org, skare_, rgustafson
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update Labels #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robliao
6 years, 7 months ago (2014-05-16 01:09:41 UTC) #1
Ilya Sherman
LGTM https://codereview.chromium.org/284313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/284313002/diff/1/tools/metrics/histograms/histograms.xml#newcode35831 tools/metrics/histograms/histograms.xml:35831: + <int value="43" label="REMINDER"/> nit: You can use ...
6 years, 7 months ago (2014-05-16 03:23:56 UTC) #2
robliao
https://codereview.chromium.org/284313002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/284313002/diff/1/tools/metrics/histograms/histograms.xml#newcode35831 tools/metrics/histograms/histograms.xml:35831: + <int value="43" label="REMINDER"/> On 2014/05/16 03:23:56, Ilya Sherman ...
6 years, 7 months ago (2014-05-16 17:00:10 UTC) #3
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 7 months ago (2014-05-16 17:00:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/284313002/20001
6 years, 7 months ago (2014-05-16 17:00:39 UTC) #5
robliao
6 years, 7 months ago (2014-05-16 19:40:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r271084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698