Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3305)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/memory/shared_memory_unittest.cc

Issue 2843113002: make base::SharedMemoryHandle a class on POSIX. (Closed)
Patch Set: Fix test error. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/memory/shared_memory_handle_posix.cc ('K') | « base/memory/shared_memory_posix.cc ('k') | base/metrics/field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_unittest.cc
diff --git a/base/memory/shared_memory_unittest.cc b/base/memory/shared_memory_unittest.cc
index d87fad01d3f0c83cc3c3534b7e4bacaf600dce68..2da99e817d880cfde7d91cc2cc4b7c4229a8c98d 100644
--- a/base/memory/shared_memory_unittest.cc
+++ b/base/memory/shared_memory_unittest.cc
@@ -221,7 +221,7 @@ TEST(SharedMemoryTest, CloseNoUnmap) {
memory.Close();
EXPECT_EQ(ptr, memory.memory());
- EXPECT_EQ(SharedMemory::NULLHandle(), memory.handle());
+ EXPECT_TRUE(!memory.handle().IsValid());
for (size_t i = 0; i < kDataSize; i++) {
EXPECT_EQ('G', ptr[i]);
« base/memory/shared_memory_handle_posix.cc ('K') | « base/memory/shared_memory_posix.cc ('k') | base/metrics/field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698