Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column.js

Issue 2843073003: DevTools: linkifier incorrectly matches port numbers in urls as line numbers (Closed)
Patch Set: added test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column.js b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column.js
new file mode 100644
index 0000000000000000000000000000000000000000..51f23e68c2e1e149fb5ec872af5f38c399e01506
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column.js
@@ -0,0 +1,16 @@
+function testSplitLineColumn(string) {
+ var result = Common.ParsedURL.splitLineAndColumn(string);
+ TestRunner.addResult("Original: " + string + ", URL: " + result.url + ', Line: ' + result.lineNumber + ', Column: ' + result.columnNumber);
+}
+
+TestRunner.addResult("Test parsing links with line and column numbers.");
+
+testSplitLineColumn("http://www.chromium.org");
dgozman 2017/04/27 17:03:29 Add to existing parsed-url.html test.
luoe 2017/04/27 17:43:58 Done.
+testSplitLineColumn("http://www.chromium.org:8000");
+testSplitLineColumn("http://www.chromium.org:8000/");
+testSplitLineColumn("http://www.chromium.org:8000/foo.js:10");
+testSplitLineColumn("http://www.chromium.org:8000/foo.js:10:20");
+testSplitLineColumn("http://www.chromium.org/foo.js:10");
+testSplitLineColumn("http://www.chromium.org/foo.js:10:20");
+
+TestRunner.completeTest();
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector-unit/parse-urls-line-column-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698