Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/LayoutTests/inspector/components/parsed-url.html

Issue 2843073003: DevTools: linkifier incorrectly matches port numbers in urls as line numbers (Closed)
Patch Set: move test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/components/parsed-url-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/components/parsed-url.html
diff --git a/third_party/WebKit/LayoutTests/inspector/components/parsed-url.html b/third_party/WebKit/LayoutTests/inspector/components/parsed-url.html
index 57098bd49e2c6825a1d21bb8cd02d8b62174fe9d..d539d41125e9c8a6bda222fe1146c27688d46c4c 100644
--- a/third_party/WebKit/LayoutTests/inspector/components/parsed-url.html
+++ b/third_party/WebKit/LayoutTests/inspector/components/parsed-url.html
@@ -39,6 +39,23 @@ function test()
parseAndDumpURL("http://example.com/foo////bar/baz.html");
parseAndDumpURL("http://example.com/foo/bar/////baz.html");
+ function testSplitLineColumn(url) {
+ var result = Common.ParsedURL.splitLineAndColumn(url);
+
+ InspectorTest.addResult("Splitting url: " + url);
+ InspectorTest.addResult(" URL: " + result.url);
+ InspectorTest.addResult(" Line: " + result.lineNumber);
+ InspectorTest.addResult(" Column: " + result.columnNumber);
+ }
+
+ testSplitLineColumn("http://www.chromium.org");
+ testSplitLineColumn("http://www.chromium.org:8000");
+ testSplitLineColumn("http://www.chromium.org:8000/");
+ testSplitLineColumn("http://www.chromium.org:8000/foo.js:10");
+ testSplitLineColumn("http://www.chromium.org:8000/foo.js:10:20");
+ testSplitLineColumn("http://www.chromium.org/foo.js:10");
+ testSplitLineColumn("http://www.chromium.org/foo.js:10:20");
+
InspectorTest.completeTest();
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/components/parsed-url-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698