Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 284303008: Fix window shape on Linux/windows by re-adding call to SetShape(). (Closed)

Created:
6 years, 7 months ago by garykac
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix window shape on Linux/windows by re-adding call to SetShape(). This call was removed in crrev.com/132343006. BUG=374473 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
garykac
6 years, 7 months ago (2014-05-17 00:30:30 UTC) #1
Wez
lgtm
6 years, 7 months ago (2014-05-17 05:32:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/284303008/1
6 years, 7 months ago (2014-05-17 05:34:33 UTC) #3
Zachary Kuznia
lgtm
6 years, 7 months ago (2014-05-17 05:43:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 11:37:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 11:40:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68285)
6 years, 7 months ago (2014-05-17 11:40:37 UTC) #7
garykac
+benwells for OWNER
6 years, 7 months ago (2014-05-17 15:40:26 UTC) #8
benwells
lgtm
6 years, 7 months ago (2014-05-19 03:29:41 UTC) #9
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 7 months ago (2014-05-19 03:29:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/284303008/1
6 years, 7 months ago (2014-05-19 03:29:52 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 03:33:46 UTC) #12
Message was sent while issue was closed.
Change committed as 271338

Powered by Google App Engine
This is Rietveld 408576698