Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 284303007: Don't close already closed connections in (Closed)

Created:
6 years, 7 months ago by Ryan Hamilton
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Don't close already closed connections in QuicClientSession::CloseSessionOnErrorInner. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/quic/quic_client_session.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Ryan Hamilton
Frankly, I'm not sure it should be an error to close an already closed connection, ...
6 years, 7 months ago (2014-05-16 21:06:11 UTC) #1
jar (doing other things)
lgtm
6 years, 7 months ago (2014-05-19 16:01:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/284303007/1
6 years, 7 months ago (2014-05-19 16:01:36 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 19:15:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 19:50:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155057)
6 years, 7 months ago (2014-05-19 19:50:49 UTC) #6
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 7 months ago (2014-05-19 23:04:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/284303007/1
6 years, 7 months ago (2014-05-19 23:06:16 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 00:24:12 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 01:23:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155207)
6 years, 7 months ago (2014-05-20 01:23:18 UTC) #11
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 7 months ago (2014-05-20 01:30:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/284303007/1
6 years, 7 months ago (2014-05-20 01:31:22 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 02:53:59 UTC) #14
Message was sent while issue was closed.
Change committed as 271548

Powered by Google App Engine
This is Rietveld 408576698