Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 284303005: Fix Gpu texture creation bug (Closed)

Created:
6 years, 7 months ago by egdaniel
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix Gpu texture creation bug When creating a resizedTexture on a device that doesn't support non power of 2 tile (Tegras), we were creating the new stretched texture but were not actually saving the result BUG=skia:2561 Committed: http://code.google.com/p/skia/source/detail?r=14765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/gpu/GrContext.cpp View 2 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
egdaniel
This code path was getting run on Tegra devices, and specifically was being exposed on ...
6 years, 7 months ago (2014-05-16 15:34:10 UTC) #1
robertphillips
lgtm. Note this effects devices lacking the GL_OES_texture_npot extension.
6 years, 7 months ago (2014-05-16 15:38:26 UTC) #2
jvanverth1
lgtm
6 years, 7 months ago (2014-05-16 15:41:56 UTC) #3
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 7 months ago (2014-05-16 17:17:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/284303005/1
6 years, 7 months ago (2014-05-16 17:17:55 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 17:22:53 UTC) #6
Message was sent while issue was closed.
Change committed as 14765

Powered by Google App Engine
This is Rietveld 408576698