Issue 284303003: Fix MacroAssembler::Prologue for Arm when FLAG_out_off_line_constant_pool is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284303003: Fix MacroAssembler::Prologue for Arm when FLAG_out_off_line_constant_pool is enabled. (Closed)

Created:
6 years, 7 months ago by rmcilroy

Modified:
6 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix MacroAssembler::Prologue for Arm when FLAG_out_off_line_constant_pool is enabled. The prologue update in r21329 changed the scoping of the PredictableCodeSizeScope. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21345

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -15 lines)			Patch
	M	src/arm/macro-assembler-arm.cc	View		1 chunk	+16 lines, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2014/05/16 13:33:51, rmcilroy wrote: > PTAL, thanks. lgtm. I didn't think it made a ...

6 years, 7 months ago (2014-05-16 13:40:00 UTC) #2

rmcilroy

On 2014/05/16 13:40:00, Yang wrote: > On 2014/05/16 13:33:51, rmcilroy wrote: > > PTAL, thanks. ...

6 years, 7 months ago (2014-05-16 14:48:57 UTC) #3

rmcilroy

6 years, 7 months ago (2014-05-16 14:49:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21345 (presubmit successful).