Chromium Code Reviews
Help | Chromium Project | Sign in
(1096)

Issue 2843028: Merge 61921 - <rdar://problem/8000667> Certain text is repeated before and af... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by inferno
Modified:
2 years, 11 months ago
Reviewers:
mitz
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Merge 61921 - <rdar://problem/8000667> Certain text is repeated before and after a line break

Reviewed by Sam Weinig.

WebCore:

Test: fast/text/bidi-explicit-embedding-past-end.html

* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine): Committing explicit embedding past the end of the range
creates BidiRuns up to the end of the range, so at that point, we can stop iterating.

LayoutTests:

* fast/text/bidi-explicit-embedding-past-end-expected.checksum: Added.
* fast/text/bidi-explicit-embedding-past-end-expected.png: Added.
* fast/text/bidi-explicit-embedding-past-end-expected.txt: Added.
* fast/text/bidi-explicit-embedding-past-end.html: Added.


BUG=44424
TBR=mitz@apple.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -28 lines) Lint Patch
A LayoutTests/fast/text/bidi-explicit-embedding-past-end.html View 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
A LayoutTests/fast/text/bidi-explicit-embedding-past-end-expected.checksum View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
A LayoutTests/fast/text/bidi-explicit-embedding-past-end-expected.png View Binary file 0 comments 0 errors Download
A LayoutTests/fast/text/bidi-explicit-embedding-past-end-expected.txt View 1 chunk +12 lines, -0 lines 0 comments 0 errors Download
M WebCore/platform/text/BidiResolver.h View 2 chunks +39 lines, -28 lines 0 comments 3 errors Download
Trybot results:
Commit:

Messages

Total messages: 1
inferno
3 years, 9 months ago #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6