Issue 2843015: Make Mac <keygen> handling accept certificates other than SSL client certificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2843015: Make Mac <keygen> handling accept certificates other than SSL client certificates. (Closed)

Created:
10 years, 6 months ago by rsleevi-old

Modified:
9 years, 7 months ago

Reviewers:
wtc, davidben

CC:
chromium-reviews, John Grabowski, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Windows and NSS implementations allow for any certificate, while the Mac implementation currenly constrains to certificates flagged for client authentication. The behaviour on other browsers is to allow any certificate for which the user has a private key, regardless of usage constraints, when handling application/x-x509-user-cert. BUG=148 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50691

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	net/base/cert_database_mac.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 6 months ago (2010-06-23 22:05:16 UTC) #2

LGTM.

This will allow people to use Chrome to enroll for an
email encryption certificate.

Can you use BUG=148 in the Description of this CL?

Please check in this CL yourself.  You'll need to
check out a new writable source tree and recreate the
CL in that source tree.  I'll email you the instructions.

Expand Messages | Collapse Messages