Chromium Code Reviews
Help | Chromium Project | Sign in
(1055)

Issue 2843015: Make Mac <keygen> handling accept certificates other than SSL client certificates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by rsleevi-old
Modified:
2 years, 11 months ago
Reviewers:
wtc, David Benjamin
CC:
chromium-reviews_chromium.org, John Grabowski, cbentzel+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Windows and NSS implementations allow for any certificate, while the Mac implementation currenly constrains to certificates flagged for client authentication. The behaviour on other browsers is to allow any certificate for which the user has a private key, regardless of usage constraints, when handling application/x-x509-user-cert.

BUG=148
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Lint Patch
M net/base/cert_database_mac.cc View 1 chunk +0 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
rsleevi-old
3 years, 10 months ago #1
wtc
3 years, 10 months ago #2
LGTM.

This will allow people to use Chrome to enroll for an
email encryption certificate.

Can you use BUG=148 in the Description of this CL?

Please check in this CL yourself.  You'll need to
check out a new writable source tree and recreate the
CL in that source tree.  I'll email you the instructions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6