Issue 2843005: Rolls WebKit 61233:61234 (Enable HTML5 Lexer)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2843005: Rolls WebKit 61233:61234 (Enable HTML5 Lexer) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by bulach

Modified:
4 years ago

Reviewers:
andreip3000, abarth

CC:
chromium-reviews

Visibility:
Public.

Description

Rolls WebKit 61233:61234 Switches over to the new HTML5 Parser, originally in http://codereview.chromium.org/2809011. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49936

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webpreferences.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_switches.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bulach

I think we should roll and enable at the same time, so if things go ...

4 years, 11 months ago (2010-06-16 12:37:14 UTC) #1

andreip3000

4 years, 11 months ago (2010-06-16 12:41:23 UTC) #2

LGTM

On 2010/06/16 12:37:14, bulach wrote:
> I think we should roll and enable at the same time, so if things go bad we can
> revert a single change.
> 
> AFAICT, we'll need to roll this change, wait for the bots to catch up, then
> rebaseline the layout tests (the bots don't have the new parsers yet, so we
> can't rebaseline the tests..)

Expand Messages | Collapse Messages