Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7636)

Unified Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 284293003: [Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_services_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service_unittest.cc
diff --git a/chrome/browser/metrics/metrics_service_unittest.cc b/chrome/browser/metrics/metrics_service_unittest.cc
index cb5580254ea02a6f80fc4ec3be59dbe1ed60626f..c67739d7edb754a15c89e6b63edce21021a964de 100644
--- a/chrome/browser/metrics/metrics_service_unittest.cc
+++ b/chrome/browser/metrics/metrics_service_unittest.cc
@@ -6,10 +6,9 @@
#include <string>
-#include "base/command_line.h"
+#include "base/bind.h"
#include "base/threading/platform_thread.h"
#include "chrome/browser/metrics/metrics_state_manager.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/scoped_testing_local_state.h"
#include "chrome/test/base/testing_browser_process.h"
@@ -90,8 +89,12 @@ class MetricsServiceTest : public testing::Test {
public:
MetricsServiceTest()
: testing_local_state_(TestingBrowserProcess::GetGlobal()),
- metrics_state_manager_(metrics::MetricsStateManager::Create(
- GetLocalState())) {
+ is_metrics_reporting_enabled_(false),
+ metrics_state_manager_(
+ metrics::MetricsStateManager::Create(
+ GetLocalState(),
+ base::Bind(&MetricsServiceTest::is_metrics_reporting_enabled,
+ base::Unretained(this)))) {
}
virtual ~MetricsServiceTest() {
@@ -108,9 +111,7 @@ class MetricsServiceTest : public testing::Test {
// Sets metrics reporting as enabled for testing.
void EnableMetricsReporting() {
- // TODO(asvitkine): Refactor the code to not need this flag and delete it.
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableMetricsReportingForTesting);
+ is_metrics_reporting_enabled_ = true;
}
// Waits until base::TimeTicks::Now() no longer equals |value|. This should
@@ -139,8 +140,13 @@ class MetricsServiceTest : public testing::Test {
}
private:
+ bool is_metrics_reporting_enabled() const {
+ return is_metrics_reporting_enabled_;
+ }
+
content::TestBrowserThreadBundle thread_bundle_;
ScopedTestingLocalState testing_local_state_;
+ bool is_metrics_reporting_enabled_;
scoped_ptr<metrics::MetricsStateManager> metrics_state_manager_;
DISALLOW_COPY_AND_ASSIGN(MetricsServiceTest);
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_services_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698