Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/Source/core/dom/ModuleScript.cpp

Issue 2842923002: Support Inline module script (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ModuleScript.cpp
diff --git a/third_party/WebKit/Source/core/dom/ModuleScript.cpp b/third_party/WebKit/Source/core/dom/ModuleScript.cpp
index 43959612670f14417584df240498bb3d6d33929a..46a9ceafa35b8536d7651502535dccf58e586371 100644
--- a/third_party/WebKit/Source/core/dom/ModuleScript.cpp
+++ b/third_party/WebKit/Source/core/dom/ModuleScript.cpp
@@ -6,8 +6,8 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ScriptValue.h"
-#include "v8/include/v8.h"
#include "bindings/core/v8/V8BindingForCore.h"
+#include "v8/include/v8.h"
namespace blink {
@@ -68,7 +68,6 @@ void ModuleScript::RunScript(LocalFrame* frame, const SecurityOrigin*) const {
String ModuleScript::InlineSourceTextForCSP() const {
// Currently we don't support inline module scripts.
// TODO(hiroshige): Implement this.
- NOTREACHED();
return String();
}

Powered by Google App Engine
This is Rietveld 408576698