Support Inline module script

third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ModulatorImpl.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/dom/ModuleMap.h"
 #include "core/dom/ModuleScript.h"
@@ skipping 66 matching lines @@
                                       const AncestorList& ancestor_list,
                                       ModuleGraphLevel level,
                                       ModuleTreeClient* client) {
   // We ensure module-related code is not executed without the flag.
   // https://crbug.com/715376
   CHECK(RuntimeEnabledFeatures::moduleScriptsEnabled());
 
   tree_linker_registry_->Fetch(request, ancestor_list, level, this, client);
 }
 
+void ModulatorImpl::FetchDescendantsForInlineScript(ModuleScript* module_script,
+                                                    ModuleTreeClient* client) {
+  map_->SetInlineModuleScript(module_script);

[hiroshige, 2017/04/26 04:48:13]

SetInlineModuleScript() is currently needed to put |module_script| (== the
inline module script) to the module map because
ScriptModuleResolverImpl::Resolve() tries to look up |module_script| itself when
we try to instantiate |module_script|'s record.

Probably we shouldn't look up |module_script| in the module map during
instantiation.
(Because it's not clear what is the key for lookup if we continue to look up;
Currently I used the base URL, but of course this causes the problem because
there can be multiple different inline scripts with the same base URL.)

What does the spec say about this?

[hiroshige, 2017/04/27 21:57:20]

Fixed.

+  tree_linker_registry_->FetchDescendantsForInlineScript(module_script, this,
+                                                         client);
+}
+
 void ModulatorImpl::FetchSingle(const ModuleScriptFetchRequest& request,
                                 ModuleGraphLevel level,
                                 SingleModuleClient* client) {
   // We ensure module-related code is not executed without the flag.
   // https://crbug.com/715376
   CHECK(RuntimeEnabledFeatures::moduleScriptsEnabled());
 
   map_->FetchSingleModuleScript(request, level, client);
 }
 
@@ skipping 101 matching lines @@
   visitor->Trace(loader_registry_);
   visitor->Trace(tree_linker_registry_);
   visitor->Trace(script_module_resolver_);
 }
 
 DEFINE_TRACE_WRAPPERS(ModulatorImpl) {
   visitor->TraceWrappers(map_);
 }
 
 }  // namespace blink