Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2842913002: Fix the front end compiler tests. (Closed)

Created:
3 years, 8 months ago by Kevin Millikin (Google)
Modified:
3 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the front end compiler tests. The front end tests run in a mode where the script is compiled to Kernel, linked with the platform libraries, and written to disk as a single binary containing both the script and platfrom libraries. Ensure that this mode continues to work. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d3fa66a559add3bde051b36147f65acc259f3978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/main.cc View 2 chunks +13 lines, -8 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 2 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 8 months ago (2017-04-25 22:07:52 UTC) #2
siva
lgtm
3 years, 8 months ago (2017-04-25 22:29:47 UTC) #3
Kevin Millikin (Google)
3 years, 8 months ago (2017-04-25 22:41:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d3fa66a559add3bde051b36147f65acc259f3978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698