[inspector] improved V8Debugger::breakProgram method

test/inspector/inspector-impl.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/inspector/inspector-impl.h"
 
 #include "include/v8.h"
 
 #include "src/vector.h"
 
@@ skipping 111 matching lines @@
     if (ready_semaphore_) ready_semaphore_->Signal();
   }
 
  private:
   InspectorClientImpl* client_;
   v8::base::Semaphore* ready_semaphore_;
 };
 
 class DisconnectTask : public TaskRunner::Task {
  public:
-  explicit DisconnectTask(InspectorClientImpl* client) : client_(client) {}
+  explicit DisconnectTask(InspectorClientImpl* client, bool reset_inspector,
+                          v8::base::Semaphore* ready_semaphore)
+      : client_(client),
+        reset_inspector_(reset_inspector),
+        ready_semaphore_(ready_semaphore) {}
   virtual ~DisconnectTask() = default;
 
   bool is_inspector_task() final { return true; }
 
   void Run(v8::Isolate* isolate,
            const v8::Global<v8::Context>& global_context) {
-    client_->disconnect();
+    client_->disconnect(reset_inspector_);
+    if (ready_semaphore_) ready_semaphore_->Signal();
   }
 
  private:
   InspectorClientImpl* client_;
+  bool reset_inspector_;
+  v8::base::Semaphore* ready_semaphore_;
 };
 
 class CreateContextGroupTask : public TaskRunner::Task {
  public:
   CreateContextGroupTask(InspectorClientImpl* client,
                          TaskRunner::SetupGlobalTasks setup_global_tasks,
                          v8::base::Semaphore* ready_semaphore,
                          int* context_group_id)
       : client_(client),
         setup_global_tasks_(std::move(setup_global_tasks)),
@@ skipping 56 matching lines @@
                                        v8_inspector::StringView());
       info.hasMemoryOnConsole = true;
       inspector_->contextCreated(info);
     }
   }
   states_.clear();
 }
 
 void InspectorClientImpl::scheduleReconnect(
     v8::base::Semaphore* ready_semaphore) {
-  task_runner_->Append(new DisconnectTask(this));
+  task_runner_->Append(
+      new DisconnectTask(this, /* reset_inspector */ true, nullptr));
   task_runner_->Append(new ConnectTask(this, ready_semaphore));
 }
 
-void InspectorClientImpl::disconnect() {
+void InspectorClientImpl::scheduleDisconnect(
+    v8::base::Semaphore* ready_semaphore) {
+  task_runner_->Append(
+      new DisconnectTask(this, /* reset_inspector */ false, ready_semaphore));
+}
+
+void InspectorClientImpl::disconnect(bool reset_inspector) {
   for (const auto& it : sessions_) {
     states_[it.first] = it.second->stateJSON();
   }
   sessions_.clear();
-  inspector_.reset();
+  if (reset_inspector) inspector_.reset();
 }
 
 void InspectorClientImpl::scheduleCreateContextGroup(
     TaskRunner::SetupGlobalTasks setup_global_tasks,
     v8::base::Semaphore* ready_semaphore, int* context_group_id) {
   task_runner_->Append(new CreateContextGroupTask(
       this, std::move(setup_global_tasks), ready_semaphore, context_group_id));
 }
 
 int InspectorClientImpl::createContextGroup(
@@ skipping 112 matching lines @@
     {
       v8::HandleScope handle_scope(isolate);
       v8::Local<v8::Context> context = global_context.Get(isolate);
       if (!context_group_id_) {
         session = InspectorClientImpl::SessionFromContext(context);
       } else {
         session = InspectorClientFromContext(context)
                       ->sessions_[context_group_id_]
                       .get();
       }
-      CHECK(session);
+      if (!session) return;
     }
     v8_inspector::StringView message_view(message_.start(), message_.length());
     session->dispatchProtocolMessage(message_view);
   }
 
  private:
   v8::internal::Vector<uint16_t> message_;
   int context_group_id_;
 };
 
@@ skipping 10 matching lines @@
 }
 
 void SendMessageToBackendExtension::SendMessageToBackend(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK(backend_task_runner_);
   CHECK(args.Length() == 2 && args[0]->IsString() && args[1]->IsInt32());
   v8::Local<v8::String> message = args[0].As<v8::String>();
   backend_task_runner_->Append(new SendMessageToBackendTask(
       ToVector(message), args[1].As<v8::Int32>()->Value()));
 }