Issue 2842853002: Remove use of WS_EX_COMPOSITED for translucent windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2842853002: Remove use of WS_EX_COMPOSITED for translucent windows. (Closed)

Created:
3 years, 8 months ago by jbauman

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove use of WS_EX_COMPOSITED for translucent windows. This style causes windows to display transparent on Windows 10 creators update with some Intel drivers on D3D9. The style itself is unnecessary, becasue based on its documentation it doesn't affect top-level window rendering, but affects only how child unredirected windows (which aren't used in Aura) render on top of their parents. BUG=712196 Review-Url: https://codereview.chromium.org/2826343002 Cr-Commit-Position: refs/heads/master@{#466207} (cherry picked from commit fec5a00d881dcf85a1a4334af1369402e183a302)

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -47 lines)			Patch
M	content/browser/compositor/software_output_device_win.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/base/win/internal_constants.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/base/win/internal_constants.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	ui/views/widget/widget_hwnd_utils.cc	View	4 chunks	+26 lines, -25 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	5 chunks	+13 lines, -12 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jbauman

3 years, 8 months ago (2017-04-25 22:55:12 UTC) #1

Description was changed from

==========
Remove use of WS_EX_COMPOSITED for translucent windows.

This style causes windows to display transparent on Windows 10 creators
update with some Intel drivers on D3D9.

The style itself is unnecessary, becasue based on its documentation it
doesn't affect top-level window rendering, but affects only how child
unredirected windows (which aren't used in Aura) render on top of their
parents.

BUG=712196

Review-Url: https://codereview.chromium.org/2826343002
Cr-Commit-Position: refs/heads/master@{#466207}
(cherry picked from commit fec5a00d881dcf85a1a4334af1369402e183a302)
==========

to

==========
Remove use of WS_EX_COMPOSITED for translucent windows.

This style causes windows to display transparent on Windows 10 creators
update with some Intel drivers on D3D9.

The style itself is unnecessary, becasue based on its documentation it
doesn't affect top-level window rendering, but affects only how child
unredirected windows (which aren't used in Aura) render on top of their
parents.

BUG=712196

Review-Url: https://codereview.chromium.org/2826343002
Cr-Commit-Position: refs/heads/master@{#466207}
(cherry picked from commit fec5a00d881dcf85a1a4334af1369402e183a302)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages