Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2842843003: DevTools: Display product information in ConsoleContextSelector (Closed)
Patch Set: f Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/Tests.js
diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js
index b0c51b9ef39a1d739d8faec5e8a17fc1041d306e..1177154b43da3fe37bb6282f7a9beac90b973615 100644
--- a/third_party/WebKit/Source/devtools/front_end/Tests.js
+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js
@@ -847,10 +847,10 @@
function onExecutionContexts() {
var consoleView = Console.ConsoleView.instance();
- var options = consoleView._consoleContextSelector._selectElement.options;
+ var items = consoleView._consoleContextSelector._list._items;
var values = [];
- for (var i = 0; i < options.length; ++i)
- values.push(options[i].value.trim());
+ for (var i = 0; i < items.length; ++i)
+ values.push(consoleView._consoleContextSelector._titleFor(items[i]));
test.assertEquals('top', values[0]);
test.assertEquals('Simple content script', values[1]);
test.releaseControl();

Powered by Google App Engine
This is Rietveld 408576698