Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html

Issue 2842843003: DevTools: Display product information in ConsoleContextSelector (Closed)
Patch Set: f Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html b/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html
index 21c236a32131a9815aff47bfccca3c9f0b33dcec..cd0116397904b44e7c3a030cf4ab10b90f6f08f7 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html
@@ -96,13 +96,13 @@ async function test()
function dump() {
var consoleView = Console.ConsoleView.instance();
- var select = consoleView._executionContextComboBox.selectElement();
+ var selector = consoleView._consoleContextSelector;
InspectorTest.addResult('Console context selector:');
- for (var i = 0; i < select.options.length; i++) {
- var option = select.options[i];
- var selected = select.selectedIndex === i;
- var text = option.text.replace(new RegExp('\u00a0', 'g'), '_');
- InspectorTest.addResult(`${selected ? '*' : ' '} ${text} ${option.disabled ? '[disabled]' : ''}`);
+ for (var executionContext of selector._list._items) {
+ var selected = selector._list.selectedItem() === executionContext;
+ var text = '____'.repeat(selector._depthFor(executionContext)) + selector._titleFor(executionContext);
+ var disabled = !selector.isItemSelectable(executionContext);
+ InspectorTest.addResult(`${selected ? '*' : ' '} ${text} ${disabled ? '[disabled]' : ''}`);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698