components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc - Issue 2842833003: Update SupportsUserData uses with unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc

Issue 2842833003: Update SupportsUserData uses with unique_ptr. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_use_measurement/core/data_use_network_delegate_unittest.cc ('k') | components/guest_view/browser/guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc

diff --git a/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc b/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc

index 2bd7ad5a2c10f9e531c545e2620f0a25a316ebd4..f22a3d12a96e6cbc5ee2921d7c5eb2d0bc9b4185 100644

--- a/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc

+++ b/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc

@@ -12,6 +12,7 @@

#include "base/android/scoped_java_ref.h"

#include "base/bind.h"

#include "base/feature_list.h"

+#include "base/memory/ptr_util.h"

#include "components/feature_engagement_tracker/internal/feature_list.h"

#include "components/feature_engagement_tracker/public/feature_engagement_tracker.h"

#include "jni/FeatureEngagementTrackerImpl_jni.h"

@@ -43,7 +44,8 @@ FeatureEngagementTrackerImplAndroid* FromFeatureEngagementTrackerImpl(

if (!impl_android) {

impl_android =

new FeatureEngagementTrackerImplAndroid(impl, GetAllFeatures());

- impl->SetUserData(kFeatureEngagementTrackerImplAndroidKey, impl_android);

+ impl->SetUserData(kFeatureEngagementTrackerImplAndroidKey,

+ base::WrapUnique(impl_android));

}

return impl_android;

}