Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: tools/plot-timer-events

Issue 284283005: Make plot shell script nicer. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/plot-timer-events
diff --git a/tools/plot-timer-events b/tools/plot-timer-events
index 8db067d5f12c800df35dc5c4e6cffbf3743150d0..87ae0a087789320154f7fe684e12719e0b2b4691 100755
--- a/tools/plot-timer-events
+++ b/tools/plot-timer-events
@@ -10,29 +10,43 @@ do
done
tools_path=`cd $(dirname "$0");pwd`
-if [ ! "$D8_PATH" ]; then
+if test ! "$D8_PATH"; then
d8_public=`which d8`
- if [ -x "$d8_public" ]; then D8_PATH=$(dirname "$d8_public"); fi
+ if test -x "$d8_public"; then D8_PATH=$(dirname "$d8_public"); fi
fi
-[ -n "$D8_PATH" ] || D8_PATH=$tools_path/..
+
+if test -n "$D8_PATH"; then
+ D8_PATH=$tools_path/..
+fi
+
d8_exec=$D8_PATH/d8
-if [ ! -x "$d8_exec" ]; then
+if test ! -x "$d8_exec"; then
D8_PATH=`pwd`/out/native
d8_exec=$D8_PATH/d8
fi
-if [ ! -x "$d8_exec" ]; then
+if test ! -x "$d8_exec"; then
d8_exec=`grep -m 1 -o '".*/d8"' $log_file | sed 's/"//g'`
fi
-if [ ! -x "$d8_exec" ]; then
+if test ! -x "$d8_exec"; then
echo "d8 shell not found in $D8_PATH"
echo "To build, execute 'make native' from the V8 directory"
exit 1
fi
-if [[ "$@" != *--distortion* ]]; then
+
+contains=0;
+for arg in "$@"; do
+ `echo "$arg" | grep -q "^--distortion"`
+ if test $? -eq 0; then
+ contains=1
+ break
+ fi
+done
+
+if test "$contains" -eq 0; then
# Try to find out how much the instrumentation overhead is.
calibration_log=calibration.log
calibration_script="for (var i = 0; i < 1000000; i++) print();"
@@ -70,7 +84,7 @@ cat $log_file |
-- $@ $options 2>/dev/null > timer-events.plot
success=$?
-if [[ $success != 0 ]] ; then
+if test $success -ne 0; then
cat timer-events.plot
else
cat timer-events.plot | gnuplot > timer-events.png
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698