media: Send chrome-cache: frfr on first request.

components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
index 6752c415e7861dbec641209707bdcbf868b57226..9d97e5d152e5b0700452f027aab27229a3e1baa3 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
@@ -261,6 +261,8 @@ void DataReductionProxyNetworkDelegate::OnBeforeSendHeadersInternal(
     data = DataReductionProxyData::GetDataAndCreateIfNecessary(request);
     if (data)
       data->set_used_data_reduction_proxy(true);
+
+    headers->RemoveHeader(chrome_proxy_header());

[bengr, 2017/05/03 21:37:42]

Please add a case to data_reduction_proxy_network_delegate_unittest.cc that
verifies that the holdback produces no chrome-proxy header even if frfr was set
previously.

[hubbe, 2017/05/05 20:51:45]

Is there a test that does something similar I can use as a template?

[bengr, 2017/05/08 21:27:38]

Shockingly there isn't. We rely on the DCHECKs in VerifyHttpRequestHeaders. To
write a test, which I won't require, you could follow the pattern of BuildSocket
(see:
https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/bro...)
but you'd need to write everything from scratch. If you don't want to do this,
please add a TODO(bengr). Thanks.

The test would go something like this:

BuildSocketForDirectConnection(...);
std::unique_ptr<net::URLRequest> request =
  context_.CreateRequest(GURL(kTestURL), net::IDLE, &delegate);

request->SetExtraRequestHeaderByName("chrome-proxy", "frfr", true);

request->Start();
base::RunLoop().RunUntilIdle();

net::HttpRequestHeaders sent_request_header;
request->GetFulLRequestHeaders(&sent_request_headers)
EXPECT_FALSE(sent_request_headers.GetHeader(chrome_proxy_header(), &val);

[hubbe, 2017/05/11 21:19:05]

Added TODO

     VerifyHttpRequestHeaders(false, *headers);
     return;
   }
@@ -288,6 +290,7 @@ void DataReductionProxyNetworkDelegate::OnBeforeSendHeadersInternal(
       lofi_decider->RemoveAcceptTransformHeader(headers);
     }
     RemoveChromeProxyECTHeader(headers);
+    headers->RemoveHeader(chrome_proxy_header());

[bengr, 2017/05/03 21:37:42]

Please add a case to data_reduction_proxy_network_delegate_unittest.cc that
verifies that Chrome produces no chrome-proxy when a direct connection or other
proxty is in use, even if frfr was set previously.

     VerifyHttpRequestHeaders(false, *headers);
     return;
   }