Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 2842753002: Reland "Use off-heap data for type feedback in PolymorphicInstanceCallInstr" (Closed)
Patch Set: Fix AOT case Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/il_printer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index 92a4d78ae6827d40867f056abe5b192822238939..9617c03b3480e0c38da4ba21e4a48e71c1708757 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -297,7 +297,7 @@ void FlowGraphTypePropagator::VisitInstanceCall(InstanceCallInstr* instr) {
void FlowGraphTypePropagator::VisitPolymorphicInstanceCall(
PolymorphicInstanceCallInstr* instr) {
if (instr->instance_call()->has_unique_selector()) {
- SetCid(instr->ArgumentAt(0), instr->ic_data().GetReceiverClassIdAt(0));
+ SetCid(instr->ArgumentAt(0), instr->targets().MonomorphicReceiverCid());
return;
}
CheckNonNullSelector(instr, instr->ArgumentAt(0),
@@ -1024,8 +1024,8 @@ CompileType AllocateUninitializedContextInstr::ComputeType() const {
CompileType PolymorphicInstanceCallInstr::ComputeType() const {
- if (!HasSingleRecognizedTarget()) return CompileType::Dynamic();
- const Function& target = Function::Handle(ic_data().GetTargetAt(0));
+ if (!IsSureToCallSingleRecognizedTarget()) return CompileType::Dynamic();
+ const Function& target = *targets_[0].target;
return (target.recognized_kind() != MethodRecognizer::kUnknown)
? CompileType::FromCid(MethodRecognizer::ResultCid(target))
: CompileType::Dynamic();
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/il_printer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698