Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 284273002: Fix a QUIC bug where a crypto packet was never removed from the (Closed) Base URL: https://chromium.googlesource.com/chromium/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.cc
diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc
index 6dc30a5f9ff5f1a2170f42caa7c93b3b72b22b47..97214f3788edcb2a4b2b29d026bca6b6875687d3 100644
--- a/net/quic/quic_sent_packet_manager.cc
+++ b/net/quic/quic_sent_packet_manager.cc
@@ -261,8 +261,14 @@ void QuicSentPacketManager::NeuterUnencryptedPackets() {
// they are not retransmitted or considered lost from a congestion control
// perspective.
pending_retransmissions_.erase(it->first);
- unacked_packets_.NeuterPacket(it->first);
unacked_packets_.SetNotPending(it->first);
+ // TODO(ianswett): Clean this up so UnackedPacketMap maintains the correct
+ // invariants between the various transmissions for NeuterPacket.
+ SequenceNumberSet all_transmissions = *it->second.all_transmissions;
+ for (SequenceNumberSet::const_iterator all_it = all_transmissions.begin();
+ all_it != all_transmissions.end(); ++all_it) {
+ unacked_packets_.NeuterPacket(*all_it);
+ }
}
}
}
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698