Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2842693005: Store physical backing size in ViewAndroid (Closed)
Patch Set: no UpdateLayerBounds Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 761677293524eb653fff0bf6ed1eb89be91a1eca..d39e6a345ea834719963c3dec02699ad8d87de5e 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -222,10 +222,6 @@ ContentViewCoreImpl::ContentViewCoreImpl(
device_orientation_(0),
accessibility_enabled_(false) {
GetViewAndroid()->SetLayer(cc::Layer::Create());
- gfx::Size physical_size(
- Java_ContentViewCore_getPhysicalBackingWidthPix(env, obj),
- Java_ContentViewCore_getPhysicalBackingHeightPix(env, obj));
- GetViewAndroid()->GetLayer()->SetBounds(physical_size);
boliu 2017/05/10 17:09:53 does that mean you need to bring these calls back?
Khushal 2017/05/10 18:13:59 Nope, its not necessary. A layer's bounds need to
// Currently, the only use case we have for overriding a user agent involves
// spoofing a desktop Linux user agent for "Request desktop site".
@@ -661,16 +657,6 @@ gfx::Size ContentViewCoreImpl::GetViewSize() const {
return size;
}
-gfx::Size ContentViewCoreImpl::GetPhysicalBackingSize() const {
- JNIEnv* env = AttachCurrentThread();
- ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
- if (j_obj.is_null())
- return gfx::Size();
- return gfx::Size(
- Java_ContentViewCore_getPhysicalBackingWidthPix(env, j_obj),
- Java_ContentViewCore_getPhysicalBackingHeightPix(env, j_obj));
-}
-
gfx::Size ContentViewCoreImpl::GetViewportSizePix() const {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
@@ -1035,11 +1021,6 @@ void ContentViewCoreImpl::RemoveJavascriptInterface(
void ContentViewCoreImpl::WasResized(JNIEnv* env,
const JavaParamRef<jobject>& obj) {
- gfx::Size physical_size(
- Java_ContentViewCore_getPhysicalBackingWidthPix(env, obj),
- Java_ContentViewCore_getPhysicalBackingHeightPix(env, obj));
- GetViewAndroid()->GetLayer()->SetBounds(physical_size);
-
SendScreenRectsAndResizeWidget();
}
« no previous file with comments | « content/browser/android/content_view_core_impl.h ('k') | content/browser/android/content_view_render_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698