Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: extensions/renderer/api_bindings_system_unittest.cc

Issue 2842673002: [Extensions Bindings] Remove Isolate arg from APIBinding::CreateInstance (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_bindings_system.cc ('k') | extensions/renderer/declarative_event_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_bindings_system_unittest.cc
diff --git a/extensions/renderer/api_bindings_system_unittest.cc b/extensions/renderer/api_bindings_system_unittest.cc
index 84f7d91ecad341b8963a19a0fc26a89cffe5b54b..b00c84658fd3890b67cb55adef045c1373e221bb 100644
--- a/extensions/renderer/api_bindings_system_unittest.cc
+++ b/extensions/renderer/api_bindings_system_unittest.cc
@@ -205,10 +205,10 @@ TEST_F(APIBindingsSystemTest, TestInitializationAndCallbacks) {
v8::Local<v8::Context> context = MainContext();
v8::Local<v8::Object> alpha_api = bindings_system()->CreateAPIInstance(
- kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
+ kAlphaAPIName, context, base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(alpha_api.IsEmpty());
v8::Local<v8::Object> beta_api = bindings_system()->CreateAPIInstance(
- kBetaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
+ kBetaAPIName, context, base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(beta_api.IsEmpty());
{
@@ -334,7 +334,7 @@ TEST_F(APIBindingsSystemTest, TestCustomHooks) {
binding_hooks->SetDelegate(std::move(test_hooks));
v8::Local<v8::Object> alpha_api = bindings_system()->CreateAPIInstance(
- kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
+ kAlphaAPIName, context, base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(alpha_api.IsEmpty());
{
@@ -372,7 +372,7 @@ TEST_F(APIBindingsSystemTest, TestSetCustomCallback) {
APIBindingHooks* hooks = nullptr;
v8::Local<v8::Object> alpha_api = bindings_system()->CreateAPIInstance(
- kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), &hooks);
+ kAlphaAPIName, context, base::Bind(&AllowAllAPIs), &hooks);
ASSERT_FALSE(alpha_api.IsEmpty());
ASSERT_TRUE(hooks);
v8::Local<v8::Object> js_hooks = hooks->GetJSHookInterface(context);
@@ -415,7 +415,7 @@ TEST_F(APIBindingsSystemTest, CrossAPIReferences) {
// alpha API yet, since this tests that we can lazily populate the type
// information.
v8::Local<v8::Object> gamma_api = bindings_system()->CreateAPIInstance(
- kGammaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
+ kGammaAPIName, context, base::Bind(&AllowAllAPIs), nullptr);
ASSERT_FALSE(gamma_api.IsEmpty());
{
@@ -449,7 +449,7 @@ TEST_F(APIBindingsSystemTest, TestCustomEvent) {
binding_hooks->SetDelegate(std::move(test_hooks));
v8::Local<v8::Object> api = bindings_system()->CreateAPIInstance(
- kAlphaAPIName, context, isolate(), base::Bind(&AllowAllAPIs), nullptr);
+ kAlphaAPIName, context, base::Bind(&AllowAllAPIs), nullptr);
v8::Local<v8::Value> event =
GetPropertyFromObject(api, context, "alphaEvent");
« no previous file with comments | « extensions/renderer/api_bindings_system.cc ('k') | extensions/renderer/declarative_event_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698