Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2842653003: Include superclasses of classes only needed for rti (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include superclasses of classes only needed for rti Closes #29441 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/86fbb962cfef0addf2aefdf1bf5fd21c7eea0d66

Patch Set 1 #

Patch Set 2 : Update status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-25 12:10:02 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
3 years, 8 months ago (2017-04-25 19:49:01 UTC) #3
Siggi Cherem (dart-lang)
btw, you should also update the .status file.
3 years, 8 months ago (2017-04-25 19:50:18 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-26 07:21:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
86fbb962cfef0addf2aefdf1bf5fd21c7eea0d66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698