Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2842643002: Move dartk to the tool folder (Closed)

Created:
3 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move dartk to the tool folder "bin" is part of the public API of a package, private tools can go under the `tool` folder. This allows us to use a dev_dependency on analyzer without exposing a broken import publicly. I've only moved `dartk` so far (which I expect will be removed once we have a better API for front_end. R=asgerf@google.com, kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/26c2f3e17fa6c566c6949069fc4c8d92a987021b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -462 lines) Patch
M pkg/kernel/README.md View 1 chunk +1 line, -1 line 0 comments Download
D pkg/kernel/bin/dartk.dart View 1 chunk +0 lines, -454 lines 0 comments Download
M pkg/kernel/bin/reified_dart.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/kernel/test/batch_consistency.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/kernel/tool/dartk.dart View 1 chunk +2 lines, -2 lines 1 comment Download
M tools/dartk_wrappers/dartk View 1 chunk +1 line, -1 line 0 comments Download
M tools/dartk_wrappers/dartk.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2842643002/diff/40001/pkg/kernel/tool/dartk.dart File pkg/kernel/tool/dartk.dart (right): https://codereview.chromium.org/2842643002/diff/40001/pkg/kernel/tool/dartk.dart#newcode9 pkg/kernel/tool/dartk.dart:9: import '../bin/batch_util.dart'; I only moved dartk to fix the ...
3 years, 8 months ago (2017-04-24 23:20:38 UTC) #3
asgerf
LGTM
3 years, 7 months ago (2017-04-28 10:28:42 UTC) #4
Siggi Cherem (dart-lang)
3 years, 7 months ago (2017-04-28 22:39:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
26c2f3e17fa6c566c6949069fc4c8d92a987021b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698