third_party/WebKit/LayoutTests/paint/invalidation/window-resize-no-layout-change1-expected.html - Issue 2842553003: Call SAC::DidScrollUpdate only for compositor-triggered scrolls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/window-resize-no-layout-change1-expected.html

Issue 2842553003: Call SAC::DidScrollUpdate only for compositor-triggered scrolls. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script>	2 <script>

3 if (window.internals) {	3 if (window.internals) {

4 internals.settings.setOverlayScrollbarsEnabled(true);	4 internals.settings.setOverlayScrollbarsEnabled(true);

5 internals.settings.setMockScrollbarsEnabled(true);	5 internals.settings.setMockScrollbarsEnabled(true);
	bokan 2017/04/25 22:56:48 Why are these window resize tests using overlay sc Why are these window resize tests using overlay scrollbars? Turning them on like this is kind of half baked since there's a mismatch between what Blink this the status is and other parts of Chrome: crbug.com/661783 If it's just to prevent layout changes due to scrollbars appearing, could we use overflow: hidden here too? skobes 2017/04/27 00:46:31 Done. Show quoted text On 2017/04/25 22:56:48, bokan wrote: > Why are these window resize tests using overlay scrollbars? Turning them on like > this is kind of half baked since there's a mismatch between what Blink this the > status is and other parts of Chrome: crbug.com/661783 > > If it's just to prevent layout changes due to scrollbars appearing, could we use > overflow: hidden here too? Done.
6 }	6 }

7 </script>	7 </script>

8 <div style="width: 2000px; height: 2000px; background-color: blue">	8 <div style="width: 2000px; height: 2000px; background-color: blue">

9 </div>	9 </div>

	10 <script>

	11 // Force scrollbar visibility.

	12 scrollTo(1, 1);

	13 scrollTo(0, 0);

	14 </script>

OLD	NEW