Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 284253006: ozone: Make sure the platform doesn't get initialized more than once. (Closed)

Created:
6 years, 7 months ago by sadrul
Modified:
6 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: Make sure the platform doesn't get initialized more than once. Trying to initialize the UI systems more than once can end up creating the same subsystem (e.g. surface-factory) multiple times, which is not supported. So remember whether the UI/GPU parts of the platform has been initialized. BUG=361137 NOTRY=true TBR=spang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ui/ozone/ozone_platform.cc View 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sadrul
Turns out we end up calling InitializeUI() on the same OzonePlatform instance once for each ...
6 years, 7 months ago (2014-05-16 05:07:00 UTC) #1
sadrul
The CQ bit was checked by sadrul@chromium.org
6 years, 7 months ago (2014-05-16 05:07:22 UTC) #2
sadrul
The CQ bit was unchecked by sadrul@chromium.org
6 years, 7 months ago (2014-05-16 05:07:24 UTC) #3
sadrul
The CQ bit was checked by sadrul@chromium.org
6 years, 7 months ago (2014-05-16 05:07:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sadrul@chromium.org/284253006/1
6 years, 7 months ago (2014-05-16 05:07:56 UTC) #5
sadrul
The CQ bit was unchecked by sadrul@chromium.org
6 years, 7 months ago (2014-05-16 05:23:13 UTC) #6
sadrul
Committed patchset #1 manually as r270939 (presubmit successful).
6 years, 7 months ago (2014-05-16 05:23:41 UTC) #7
commit-bot: I haz the power
Failed to commit the patch. Sending ui/ozone/ozone_platform.cc Transmitting file data .svn: Commit failed (details follow): ...
6 years, 7 months ago (2014-05-16 05:24:08 UTC) #8
spang
6 years, 7 months ago (2014-05-16 15:01:57 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698