Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2842523002: Fix detection of bad catch-clauses and try-statements (Closed)

Created:
3 years, 8 months ago by messick
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -26 lines) Patch
M pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart View 3 chunks +23 lines, -15 lines 1 comment Download
M pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart View 4 chunks +32 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
messick
3 years, 8 months ago (2017-04-24 18:49:22 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2842523002/diff/1/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart File pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart (right): https://codereview.chromium.org/2842523002/diff/1/pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart#newcode180 pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart:180: node = blockNode.statements[blockNode.statements.length - 1]; blockNode.statements.last
3 years, 8 months ago (2017-04-24 18:52:33 UTC) #3
messick
Thanks! I'll make that change for the next CL.
3 years, 8 months ago (2017-04-24 18:58:35 UTC) #4
messick
3 years, 8 months ago (2017-04-24 19:00:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c2aae7deece8f4ff6ba0bd26cb14f21aa59108d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698