Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 284243002: Fix js_to_cpp_unittest handling of null arrays. (Closed)

Created:
6 years, 7 months ago by Tom Sepez
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen1
Base URL:
https://chromium.googlesource.com/chromium/src
Visibility:
Public.

Description

Fix js_to_cpp_unittest handling of null arrays. This test is still disabled pending resolution of some mojo message validation issues, but this version sould be correct given a correct message validator. In other words, running this with --gtest_also_run_disabled_tests is a good way to test a message validator. BUG=366797 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Tom Sepez
Trung for OWNERS review.
6 years, 7 months ago (2014-05-15 19:10:22 UTC) #1
viettrungluu
lgtm
6 years, 7 months ago (2014-05-15 19:15:30 UTC) #2
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-15 19:16:09 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 19:20:07 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 7 months ago (2014-05-15 19:20:07 UTC) #5
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 7 months ago (2014-05-15 21:35:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/284243002/1
6 years, 7 months ago (2014-05-15 21:35:59 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 22:34:11 UTC) #8
Message was sent while issue was closed.
Change committed as 270834

Powered by Google App Engine
This is Rietveld 408576698