Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3518)

Unified Diff: cc/output/overlay_unittest.cc

Issue 2842383003: cc: Don't subtract transparent overlay from damage. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/overlay_processor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/overlay_unittest.cc
diff --git a/cc/output/overlay_unittest.cc b/cc/output/overlay_unittest.cc
index 70d81f6fc6b5b91cad316212a151b30d23c6c814..456ba495981a61222bf8c4a37824e03b5b0b9ec6 100644
--- a/cc/output/overlay_unittest.cc
+++ b/cc/output/overlay_unittest.cc
@@ -757,7 +757,7 @@ TEST_F(SingleOverlayOnTopTest, DamageRect) {
resource_provider_.get(), pass.get(), render_pass_filters,
render_pass_background_filters, &candidate_list, nullptr, nullptr,
&damage_rect_, &content_bounds_);
- DCHECK(damage_rect_.IsEmpty());
+ EXPECT_TRUE(damage_rect_.IsEmpty());
}
TEST_F(SingleOverlayOnTopTest, NoCandidates) {
@@ -850,11 +850,13 @@ TEST_F(SingleOverlayOnTopTest, AcceptBlending) {
OverlayCandidateList candidate_list;
base::flat_map<int, FilterOperations*> render_pass_filters;
base::flat_map<int, FilterOperations*> render_pass_background_filters;
+ damage_rect_ = quad->rect;
overlay_processor_->ProcessForOverlays(
resource_provider_.get(), pass.get(), render_pass_filters,
render_pass_background_filters, &candidate_list, nullptr, nullptr,
&damage_rect_, &content_bounds_);
EXPECT_EQ(1U, candidate_list.size());
+ EXPECT_FALSE(damage_rect_.IsEmpty());
}
TEST_F(SingleOverlayOnTopTest, RejectBackgroundColor) {
« no previous file with comments | « cc/output/overlay_processor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698