Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 284233007: Do not call event.preventDefault() on touchstart for menu items. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Do not call event.preventDefault() on touchstart for menu items. preventDefault() on 'touchstart' prevents tap operation from dispatching click-like events. On 'touchstart', preventDefault() should not be called. BUG=374177 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/webui/resources/js/cr/ui/context_menu_handler.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
fukino
@arv, I'm sorry, I made a regression by previous CL(284233007). Could you take a look ...
6 years, 7 months ago (2014-05-16 13:16:01 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 7 months ago (2014-05-16 14:23:38 UTC) #2
fukino
On 2014/05/16 14:23:38, arv wrote: > LGTM Thank you for your prompt review!
6 years, 7 months ago (2014-05-16 14:28:32 UTC) #3
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-16 14:28:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/284233007/1
6 years, 7 months ago (2014-05-16 14:28:52 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 16:24:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 16:44:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27877)
6 years, 7 months ago (2014-05-16 16:44:21 UTC) #8
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-17 05:21:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/284233007/1
6 years, 7 months ago (2014-05-17 05:21:49 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 15:33:46 UTC) #11
Message was sent while issue was closed.
Change committed as 271204

Powered by Google App Engine
This is Rietveld 408576698