Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 284233005: cc: CapturePostTask in SingleThreadProxy::Stop (Closed)

Created:
6 years, 7 months ago by boliu
Modified:
6 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: CapturePostTask in SingleThreadProxy::Stop Impl side posts callbacks for releasing resources on SingleThreadProxy::Stop, and there is no reason to have these be real post tasks. BUG=344087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271063

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/trees/single_thread_proxy.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
boliu
Start with a small one line change..
6 years, 7 months ago (2014-05-16 01:32:17 UTC) #1
danakj
LGTM https://codereview.chromium.org/284233005/diff/1/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/284233005/diff/1/cc/trees/single_thread_proxy.cc#newcode221 cc/trees/single_thread_proxy.cc:221: BlockingTaskRunner::CapturePostTasks blocked; nit: move this down beside the ...
6 years, 7 months ago (2014-05-16 15:10:34 UTC) #2
boliu
https://codereview.chromium.org/284233005/diff/1/cc/trees/single_thread_proxy.cc File cc/trees/single_thread_proxy.cc (right): https://codereview.chromium.org/284233005/diff/1/cc/trees/single_thread_proxy.cc#newcode221 cc/trees/single_thread_proxy.cc:221: BlockingTaskRunner::CapturePostTasks blocked; On 2014/05/16 15:10:35, danakj wrote: > nit: ...
6 years, 7 months ago (2014-05-16 15:41:46 UTC) #3
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 7 months ago (2014-05-16 15:41:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/284233005/20001
6 years, 7 months ago (2014-05-16 15:42:04 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 18:24:23 UTC) #6
Message was sent while issue was closed.
Change committed as 271063

Powered by Google App Engine
This is Rietveld 408576698