Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/dom/scripts/systemnative.py

Issue 284233004: More native binding match up fixes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/systemnative.py
diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py
index 497aa1482060212bf3acaa8d59c292412541339d..3780bcda5b5b45742880105e5ab6e1107d713b87 100644
--- a/tools/dom/scripts/systemnative.py
+++ b/tools/dom/scripts/systemnative.py
@@ -565,7 +565,11 @@ class DartiumBackend(HtmlDartGenerator):
constructor_callback_cpp_name = cpp_prefix + cpp_suffix
if arguments is None:
- argument_count = len(constructor_info.param_infos)
+ if self._dart_use_blink:
+ arguments = constructor_info.idl_args[0]
+ argument_count = len(arguments)
+ else:
+ argument_count = len(constructor_info.param_infos)
else:
argument_count = len(arguments)
@@ -573,7 +577,7 @@ class DartiumBackend(HtmlDartGenerator):
parameters = constructor_info.ParametersAsStringOfVariables(argument_count)
interface_name = self._interface_type_info.interface_name()
- if self._dart_use_blink and arguments:
+ if self._dart_use_blink:
type_ids = [p.type.id for p in arguments]
constructor_callback_id = \
DeriveResolverString(self._interface.id,
« no previous file with comments | « sdk/lib/_blink/dartium/_blink_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698