chrome/browser/resources/settings/search_engines_page/search_engine_entry.js - Issue 2842303004: MD Settings: update dialogs to focus without ink when using mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 2842303004: MD Settings: update dialogs to focus without ink when using mouse (Closed)

Patch Set: different approach Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | chrome/browser/resources/settings/search_engines_page/search_engines_page.html » ('j') | ui/webui/resources/js/cr/ui/focus_without_ink.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

index 7fe468481246c8ffb2e718cce143fa09d1c5f2c9..233ae2da4ae26280e71c9946964af6c3e93fe8b1 100644

--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

@@ -106,7 +106,7 @@ Polymer({

// previous dialog's contents are cleared.

dialog.addEventListener('close', function() {

this.showEditSearchEngineDialog_ = false;

- this.$$('paper-icon-button').focus();

+ cr.ui.focusWithoutInk(this.$$('paper-icon-button'));

}.bind(this));