chrome/browser/resources/settings/about_page/detailed_build_info.js - Issue 2842303004: MD Settings: update dialogs to focus without ink when using mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/detailed_build_info.js

Issue 2842303004: MD Settings: update dialogs to focus without ink when using mouse (Closed)

Patch Set: merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/compiled_resources.gyp ('K') | « chrome/browser/resources/settings/about_page/detailed_build_info.html ('k') | chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html » ('j') | ui/webui/resources/js/cr/ui/focus_without_ink.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/detailed_build_info.js

diff --git a/chrome/browser/resources/settings/about_page/detailed_build_info.js b/chrome/browser/resources/settings/about_page/detailed_build_info.js

index 33a90b780c461c96e70c95628ead4ad30ba2909e..9873b40bf941472ecc07d889e52a7e832d810db6 100644

--- a/chrome/browser/resources/settings/about_page/detailed_build_info.js

+++ b/chrome/browser/resources/settings/about_page/detailed_build_info.js

@@ -94,7 +94,7 @@ Polymer({

/** @private */

onChannelSwitcherDialogClosed_: function() {

this.showChannelSwitcherDialog_ = false;

- this.$$('paper-button').focus();

+ settings.focusWithoutInk(this.$$('paper-button'));

dpapad 2017/04/28 17:36:46 Should this be cr.ui.focusWithoutInk (here and els

Dan Beam 2017/04/29 02:56:31 Done. (whoops, guess this file is neither tested n

this.updateChannelInfo_();

});