chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js - Issue 2842303004: MD Settings: update dialogs to focus without ink when using mouse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js

Issue 2842303004: MD Settings: update dialogs to focus without ink when using mouse (Closed)

Patch Set: you wanted this... Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html ('k') | chrome/browser/resources/settings/android_apps_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js

diff --git a/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js b/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js

index c11083464cf7e3e8b970cbdea98a823a0960f368..9dae8ffd8403d2b9a06e8160b58746fcc3fe1d1c 100644

--- a/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js

+++ b/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.js

@@ -93,6 +93,6 @@ Polymer({

/** @private */

onConfirmDisableDialogClose_: function() {

- this.$$('#remove button').focus();

+ cr.ui.focusWithoutInk(assert(this.$$('#remove button')));

dpapad 2017/05/02 03:03:43 Nit (not for this CL): We can probably use getRequ

Dan Beam 2017/05/02 21:34:25 Acknowledged.

});